Skip to content

Migrate releases to release-please - #76

Merged
kwent merged 1 commit into
masterfrom
devin/1793459343-release-please
Oct 31, 2026
Merged

kwent merged 1 commit into
masterfrom
devin/1793459343-release-please

Conversation

@kwent

@kwent kwent commented Oct 31, 2026

Copy link
Copy Markdown
Member

Summary

Moves releases to release-please, matching rootly-desktop / rootly-mcp-server / rootly-go. A release PR opens on pushes to master; merging it cuts the tag, GitHub release, and dispatch to release.yml (a GITHUB_TOKEN-created tag does not fire push: tags, hence the dispatch). Replaces manual make release-* tagging.

  • Adds release-please-config.json + .release-please-manifest.json (seeded at 0.6.1)
  • release-please.yml runs googleapis/release-please-action v5, then gh workflow run release.yml --ref $TAG
  • release.yml gains workflow_dispatch
  • .goreleaser.yaml: mode: replace → keep-existing so GoReleaser attaches artifacts to the release-please release instead of overwriting its notes

Manual v* tag pushes still run the release workflow as before. Rollback = revert this PR.

Link to Devin session: https://rootly.devinenterprise.com/sessions/774103253f13428589402ae6862eeaeb
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/774103253f13428589402ae6862eeaeb?variant=devin
Requested by: @kwent

Adds release-please (googleapis/release-please-action v5) to own the
version bump, tag, and GitHub release. The goreleaser workflow gains a
workflow_dispatch trigger and is kicked off when release-please cuts a
release (GITHUB_TOKEN-created tags don't fire push/tags triggers).
GoReleaser mode switches replace -> keep-existing so it attaches
artifacts to the release-please release instead of overwriting its
notes.

Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
@kwent
kwent requested a review from a team October 31, 2026 15:12
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable release-flow defects were found.

Summary

Moves release creation to release-please, then dispatches GoReleaser at the new tag.

  • Releases now move from a master commit through review to published CLI builds.

kwent explicitly states that manual v* tag releases remain supported, so retaining the manual release targets is intentional.

Reviews (1) · Last reviewed commit: "Migrate releases to release-please" · Reviewed by Greptile

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review pass (Devin):

  • Manifest 0.6.1 matches latest remote tag v0.6.1; trigger on master; config + workflow YAML parse clean.
  • release-please.yml dispatches release.yml with actions: write; GoReleaser keep-existing covers the manual-tag path.
  • CI: all green (lint/build/test matrix).

@kwent
kwent merged commit 0fb0539 into master Oct 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant