Repository navigation
Migrate releases to release-please - #76
Merged
Merged
Conversation
Adds release-please (googleapis/release-please-action v5) to own the version bump, tag, and GitHub release. The goreleaser workflow gains a workflow_dispatch trigger and is kicked off when release-please cuts a release (GITHUB_TOKEN-created tags don't fire push/tags triggers). GoReleaser mode switches replace -> keep-existing so it attaches artifacts to the release-please release instead of overwriting its notes. Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
[Medium impact] The PR appears safe to merge; no actionable release-flow defects were found. SummaryMoves release creation to release-please, then dispatches GoReleaser at the new tag.
Reviews (1) · Last reviewed commit: "Migrate releases to release-please" · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
Self-review pass (Devin):
- Manifest
0.6.1matches latest remote tagv0.6.1; trigger onmaster; config + workflow YAML parse clean. release-please.ymldispatchesrelease.ymlwithactions: write; GoReleaserkeep-existingcovers the manual-tag path.- CI: all green (lint/build/test matrix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves releases to release-please, matching rootly-desktop / rootly-mcp-server / rootly-go. A release PR opens on pushes to
master; merging it cuts the tag, GitHub release, and dispatch torelease.yml(a GITHUB_TOKEN-created tag does not firepush: tags, hence the dispatch). Replaces manualmake release-*tagging.release-please-config.json+.release-please-manifest.json(seeded at 0.6.1)release-please.ymlrunsgoogleapis/release-please-actionv5, thengh workflow run release.yml --ref $TAGrelease.ymlgainsworkflow_dispatch.goreleaser.yaml:mode: replace→keep-existingso GoReleaser attaches artifacts to the release-please release instead of overwriting its notesManual
v*tag pushes still run the release workflow as before. Rollback = revert this PR.Link to Devin session: https://rootly.devinenterprise.com/sessions/774103253f13428589402ae6862eeaeb
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/774103253f13428589402ae6862eeaeb?variant=devin
Requested by: @kwent