Fix several minor issues - #306
Merged
Merged
Conversation
Previously only pytest itself was detected at configure time. If pytest-benchmark or pytest-csv were missing, the Python benchmarks were still registered as tests and then failed at runtime, because the pytest invocation uses the --csv option. Now all required modules are checked at configure time; if any is missing, a warning lists the missing modules and invites to install them from requirements.txt, and the Python benchmarks are skipped. Closes root-project#123, closes root-project#150.
This speeds up repeated executions of the RNTuple tests considerably, since the H1 dst conversion is skipped when the output ntuple is already there. Delete the output files to force regeneration. Closes root-project#132.
hadd is used by the setup fixtures of several benchmarks. Locate it at configuration time and fail with a clear error if it cannot be found, instead of failing at test runtime. When building as part of ROOT, hadd from the same build tree is used, since it does not exist yet at configuration time. Closes root-project#193.
The RNTuple classes graduated from the ROOT::Experimental namespace to the ROOT namespace, so the code didn't compile anymore against recent ROOT versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123
Closes #150
Closes #132
Closes #149
Closes #193