[ntuple] Add missing headers to CMakeLists - #23242
Open
hageboeck wants to merge 2 commits into
Open
Conversation
Previously, optional headers were passed to a variable that didn't get used. Here, they are passed to ROOT's CMake macro, so they can be used to conditionally install the headers in a subsequent commit.
jblomer
approved these changes
Sep 3, 2026
Test Results 23 files 23 suites 3d 22h 7m 55s ⏱️ For more details on these failures, see this check. Results for commit b80166c. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was split off from #19543. The goal of that PR is to test installed headers for include errors, and this means that we should only install headers that can actually work.
In order to achieve this, I want to convert RNT and RDF from globbing all headers behind the scenes to listing the active headers explicitly. This is the first step: headers that had been omitted from the list are added. This PR in isolation doesn't change anything, because for now, headers will still be globbed behind the scenes.
In #19543, RNT will be converted to using only the headers which are actually listed.