Flamegraph visualisers improvements - #23241
Open
albfsg wants to merge 2 commits into
Open
Conversation
Previously checksums where not represented in the method. Now they are counted as part of a page.
In this way user can call these methods as:
```cpp
inspector->PrintSchemaProfile()
```
instead of:
```cpp
inspector->PrintSchemaProfile(
ROOT::Experimental::ESchemaProfileFormat::kSpeedscopeJSON)
```
Swap the order of the `format` and `output` parameters.
Specifying where to write the profile without caring about the
format is probably a more common use case than caring about the
format (which currently has no alternatives anyway) while not
caring where the output goes.
albfsg
force-pushed
the
print_disk_profile
branch
from
September 3, 2026 06:52
f46eb16 to
92d9719
Compare
Test Results 22 files 22 suites 3d 10h 31m 28s ⏱️ For more details on these failures, see this check. Results for commit 92d9719. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
PrintDiskProfile)PrintDiskProfileandPrintSchemaProfileto include a default format parameter (concerns both methods)Checklist:
This PR fixes #