[ci][wheels] Derive the wheel version from RVersion.hxx - #23203
Open
siliataider wants to merge 1 commit into
Open
[ci][wheels] Derive the wheel version from RVersion.hxx#23203siliataider wants to merge 1 commit into
siliataider wants to merge 1 commit into
Conversation
siliataider
added
the
build-python-wheels
vepadulano
approved these changes
Aug 31, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
Thanks! LGTM once the CI for wheels is green.
Test Results 23 files 23 suites 3d 16h 51m 25s ⏱️ For more details on these failures, see this check. Results for commit 5ba7d56. |
Contributor
Author
|
The failing tests are unrelated, should be fixed after #23235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
The wheel
versioninpyproject.tomlwas hard-coded (0.1a14) and had to be edited by hand for every release. This replaces it with a scikit-build-core regex dynamic-metadata provider that parses ROOT's version macros fromcore/foundation/inc/ROOT/RVersion.hxxand appends a PEP 440 pre-release suffixa1.Ex.: ROOT
6.42.02→ wheel6.42.2a1.Note
The
a1→a2bump is manual and should only be used to re-publish a wheel for a ROOT version already on PyPI in case of issues during the first upload attempt; reset toa1for the next ROOT release.