[ntuple] Schema evolution fixes - #23196
Open
jblomer wants to merge 3 commits into
Open
Conversation
jblomer
force-pushed
the
ntuple-fix-evolution
branch
3 times, most recently
from
August 30, 2026 21:58
fe4b41b to
a879404
Compare
Test Results 21 files 21 suites 3d 0h 28m 11s ⏱️ For more details on these failures, see this check. Results for commit 4c9c7d4. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
ntuple-fix-evolution
branch
3 times, most recently
from
September 1, 2026 11:30
35b0064 to
1942bf1
Compare
If during schema evolution a conversion streamer info is required, we have to load the schema info records from the ROOT file. If the RNTuple is loaded through the RMiniFile, this requires an extra call.
hahnjo
reviewed
Sep 2, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Some considerations for simplification
Comment on lines
+555
to
+558
| if (fieldDesc.GetTypeVersion() != GetTypeVersion() || fieldDesc.GetTypeName() != GetTypeName()) { | ||
| // We need the on-disk streamer info for the conversion streamer info | ||
| pageSource.LoadStreamerInfo(); | ||
| } |
Member
There was a problem hiding this comment.
Is this an optimization to only load the streamer infos when needed? How much would it cost to always load them when opening the file?
jblomer
force-pushed
the
ntuple-fix-evolution
branch
from
September 2, 2026 20:03
1942bf1 to
4c9c7d4
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23146
Fixes #17713