Source outside of inner loop for read target#79
Open
undefined-panda wants to merge 1 commit into
Open
Conversation
hahnjo
self-requested a review
July 17, 2026 06:34
hahnjo
reviewed
Jul 17, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Makes sense, but can you please put the PR summary also as commit message, which is what we are going to merge into the repository?
Avoids re-sourcing the ROOT setup script on every write_dir iteration when invoking the read target
undefined-panda
force-pushed
the
improve-makefile-source
branch
from
July 17, 2026 11:04
b10ed84 to
7bcc773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of sourcing for each iteration of the inner loop, source outside and call inner loop afterwards