Add test for attributes#77
Merged
Merged
Conversation
jblomer
reviewed
Jun 30, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
In principle looks good to me. Since we are at it, I think we should make the test slightly more interesting and write three entries, with one attribute attached to the first entry and another attribute attached to the second and third entry.
And then, for a corner case, also test an attribute for an empty RNTuple.
hahnjo
reviewed
Jul 1, 2026
undefined-panda
force-pushed
the
attributes-test
branch
3 times, most recently
from
July 8, 2026 13:01
0fa2cd4 to
047cee5
Compare
hahnjo
reviewed
Jul 13, 2026
hahnjo
reviewed
Jul 13, 2026
undefined-panda
force-pushed
the
attributes-test
branch
from
July 14, 2026 11:43
e84cbd2 to
93792a4
Compare
hahnjo
reviewed
Jul 15, 2026
undefined-panda
force-pushed
the
attributes-test
branch
from
July 16, 2026 12:25
960479b to
64c50a3
Compare
hahnjo
reviewed
Jul 16, 2026
undefined-panda
force-pushed
the
attributes-test
branch
from
July 16, 2026 13:15
ec58ba0 to
bb2b324
Compare
hahnjo
reviewed
Jul 17, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Sorry, last two things I just noticed
undefined-panda
force-pushed
the
attributes-test
branch
from
July 17, 2026 11:19
f8e5e0a to
57149f0
Compare
hahnjo
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip write.C for versions that don't support attributes (everything before 6.40) and read.C if binary for attributes doesn't exist.
Closes #69