fix(commonjs): unwrap require() of external CommonJS modules on Node >= 23

[s1gr1d]

Rollup Plugin Name: {name}

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

Description

On Node 23+, requireReturnsDefault: 'auto' hands bundled CommonJS code a namespace object where plain Node would return module.exports.

The runtime helper getDefaultExportFromNamespaceIfNotNamed unwraps a required external module only when default is the sole key on its namespace. Since nodejs/node#53848 (Node 23), a CommonJS namespace always carries a second key, 'module.exports':

​js Object.keys(await import('mquery')); // Node 22: ['default'] // Node 23+: ['default', 'module.exports'] ​

So the check never passes, the requiring code receives the namespace, and calls like new mquery() throw mquery is not a constructor. Nuxt and SolidStart apps hit this through Nitro, which bundles database drivers while keeping the drivers' dependencies external (see getsentry/sentry-javascript#24775 for a full analysis).

The fix: when the namespace has a 'module.exports' key, return its value. Node puts the real module.exports behind that key, so this is exactly what require() would return, with no guessing. Namespaces without the key keep the current behavior, so nothing changes on Node 22 or for genuine ES modules.

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Fixes CommonJS module unwrapping for Node 23 compatibility.

The PR appears safe to merge on the findings eligible for this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[External require in auto mode] --> B[Import namespace]
  B --> C{module.exports and default have the same value?}
  C -->|Yes, including NaN| D[Return module.exports]
  C -->|No| E{Default is the only key?}
  E -->|Yes| F[Return default]
  E -->|No| G[Return namespace]

Loading

_{Reviews (3) · Last reviewed commit: "address comment"}