Update GGML to latest master#41
Open
Skyrion9 wants to merge 3 commits into
Open
Conversation
- Many fixes & perf updates in general. - Seems to have some important updates for vulkan including fp16: 1 -> fp16: dot2 which should be more efficient. "ggml_vulkan: 0 = AMD Radeon RX 6700 (RADV NAVI22) (radv) | uma: 0 | fp16: dot2 | bf16: 0 | warp size: 32 | shared memory: 65536 | int dot: 1 | matrix cores: none"
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR disables automatic local-patch application by default, updates the ggml revision, and revises CUDA convolution kernel iteration and launch block sizing. ChangesCUDA and build updates
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ggml_vulkan: 0 = AMD Radeon RX 6700 (RADV NAVI22) (radv) | uma: 0 | fp16: dot2 | bf16: 0 | warp size: 32 | shared memory: 65536 | int dot: 1 | matrix cores: nonehttps://github.com/ggml-org/ggml/tree/57ea0bc119d722d74594196cc5b494a34dd87be4
https://github.com/ggml-org/ggml
Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
Build Changes
Maintenance
ggmlcomponent to a newer revision.