Skip to content

Update GGML to latest master#41

Open
Skyrion9 wants to merge 3 commits into
rodrigomatta:mainfrom
Skyrion9:ggml-update
Open

Update GGML to latest master#41
Skyrion9 wants to merge 3 commits into
rodrigomatta:mainfrom
Skyrion9:ggml-update

Conversation

@Skyrion9

@Skyrion9 Skyrion9 commented Jul 15, 2026

Copy link
Copy Markdown
  • Many fixes & perf updates in general, we're 316 commits behind as of this PR.
  • Seems to have some important updates for vulkan including fp16: 1 -> fp16: dot2 which should be more efficient.
    ggml_vulkan: 0 = AMD Radeon RX 6700 (RADV NAVI22) (radv) | uma: 0 | fp16: dot2 | bf16: 0 | warp size: 32 | shared memory: 65536 | int dot: 1 | matrix cores: none
  • Makes the auto-patches obsolete (needs testing, I don't have CUDA hardware.)

https://github.com/ggml-org/ggml/tree/57ea0bc119d722d74594196cc5b494a34dd87be4

https://github.com/ggml-org/ggml

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes

    • Improved CUDA convolution handling so large workloads reliably process all output elements.
    • Updated CUDA kernel execution to use safer grid-stride coverage and adjusted launch sizing for more consistent results.
  • Build Changes

    • Local patches are no longer applied automatically by default during builds (can be re-enabled when needed).
  • Maintenance

    • Updated the bundled ggml component to a newer revision.

Skyrion9 added 2 commits July 15, 2026 05:44
- Many fixes & perf updates in general.
- Seems to have some important updates for vulkan including fp16: 1 ->  fp16: dot2 which should be more efficient.
"ggml_vulkan: 0 = AMD Radeon RX 6700 (RADV NAVI22) (radv) | uma: 0 | fp16: dot2 | bf16: 0 | warp size: 32 | shared memory: 65536 | int dot: 1 | matrix cores: none"
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b9b0b127-975f-4c88-96fc-3a98ee8e7899

📥 Commits

Reviewing files that changed from the base of the PR and between b0b4b25 and 584ad64.

📒 Files selected for processing (1)
  • ggml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ggml

📝 Walkthrough

Walkthrough

The PR disables automatic local-patch application by default, updates the ggml revision, and revises CUDA convolution kernel iteration and launch block sizing.

Changes

CUDA and build updates

Layer / File(s) Summary
CUDA convolution patch update
ggml, patches/ggml-conv2d-dw-grid-fix.patch
The ggml reference advances, and the depthwise CUDA convolution patch adds grid-stride processing, the required header, and capped block counts.
Local patch application default
CMakeLists.txt
S2_AUTO_APPLY_LOCAL_PATCHES now defaults to OFF.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating GGML to a newer upstream master commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant