Repository navigation
refactor(app): replace the scan semaphore with a limited dispatcher - #91
Merged
Merged
Conversation
Scans and batch pushes that someone is waiting on now run on Dispatchers.IO.limitedParallelism(8) instead of taking permits from Semaphore(8). This matches the background scans, which already work this way. RepoOps.push takes the dispatcher as a parameter, as RepoScanner.scan does. Both switch to their own dispatcher internally, so wrapping the call in withContext would escape the limit. Single-repo commit, stash apply/drop and fast-forward are no longer limited. Each is one repo's git calls in a row, and the semaphore only made them wait behind a batch scan. Their withContext(Dispatchers.Default) wrappers are gone too: RepoOps already switches to IO. Signed-off-by: Raman Gupta <rocketraman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #89, which gave background scans their own
limitedParallelism(2)dispatcher. This replaces the remainingSemaphore(8)the same way.Change
scanLimiteris replaced byforegroundGit = Dispatchers.IO.limitedParallelism(8). It's used for scans someone is waiting on: startup, Refresh, adding repos, and foregroundrescanRepos. Push all uses it too.RepoOps.pushtakes adispatcherparameter, likeRepoScanner.scan. Both switch to their own dispatcher internally, so wrapping the call inwithContextwould escape the limit.rescanReposnow picksbackgroundScansorforegroundGitin one line.Behavior change
Single-repo commit, stash apply/drop and fast-forward are no longer limited. Each is one repo's git calls in a row, and the semaphore only made them wait behind a batch scan for a slot. Their
withContext(Dispatchers.Default)wrappers are gone too, sinceRepoOpsalready switches to IO.Testing