Skip to content

v1.24.3 CLI deploys rocketpool/smartnode:v1.24.2: RP_IMAGE_SMARTNODE not bumped (and tag version.txt still 1.24.2) #1256

Description

@alchemydc

The v1.24.3 CLI reports rocketpool version 1.24.3, but its embedded mainnet.env still pins the node daemon image at v1.24.2:

RP_IMAGE_SMARTNODE=rocketpool/smartnode:v1.24.2@sha256:0e94df463f2fb461e16f9b45e8eaae38caa639e714167d6f28b2c8f6570bc7a5

Evidence

  • shared/services/rocketpool/assets/install/mainnet.env at tag v1.24.3 (ed2cf520) bumps every client image (Lighthouse v8.2.3, Besu v26.9.0, Nethermind 2.0.0, …) but leaves RP_IMAGE_SMARTNODE unchanged.
  • The released rocketpool-cli-linux-amd64 (sha256 0debd730cd9eca9e84525babbe88cccc1f27f72789beec46424c707c3ae6a7b1) embeds rocketpool/smartnode:v1.24.2. The string smartnode:v1.24.3 doesn't appear in it.
  • rocketpool/smartnode:v1.24.3 was pushed to Docker Hub (sha256:14d344d03e742…), but no released CLI references it.
  • Related: shared/version.txt at the v1.24.3 tag reads 1.24.2, yet the released binary reports 1.24.3. The release seems to have been built from an uncommitted version bump, so the tag doesn't reproduce the published binaries.

Impact

  • After service install + service start, the node container runs the v1.24.2 daemon. Daemon-side fixes in the release notes, such as Remove recover timeout (Remove recover timeout #1243), don't take effect.
  • rocketpool service version should show the client at 1.24.3 and the service at 1.24.2, which is confusing and breaks automation that checks the running node image against the release tag.

Suggested fix
Commit version.txt = 1.24.3, set RP_IMAGE_SMARTNODE to rocketpool/smartnode:v1.24.3@sha256:<digest>, and cut v1.24.4 (or re-cut v1.24.3 and say so, since the asset hashes would change).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions