docs: Mais Retorno Free quota limits in resolver cascade - #44
Conversation
Make the optional resolver cascade step explicit about operator-owned API keys and the public Free tier (500 credits/month), so deploy wiring does not treat it as unlimited. Co-authored-by: Cursor <cursoragent@cursor.com>
Correct variable per-call credit costs and separate REST API-key wiring from MCP OAuth so the cascade docs do not imply one credit per resolution or the wrong auth path. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe change documents Mais Retorno as an optional resolver source. It records REST API key and MCP OAuth authentication, shared Free-tier limits, rate-limit behavior, source classification, and provider replacement semantics. ChangesMais Retorno resolver documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to The PR clarifies Mais Retorno Free-tier limits and related resolver behavior; no actionable merge-blocking risk remains based on the supplied current-head evidence. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/findata/resolver/engine.py (1)
10-13: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winUse deployment-side wording for provider ownership.
client-side / networkedis ambiguous and conflicts with the server-side REST provider described indocs/RESOLVER.md. It can suggest placing the REST API key in browser code. Useoutside the library / networked, and state that REST credentials remain in the operator's deployment. The provider documentation recommendsX-Api-Keyfor server-side REST and OAuth for MCP. (developers.maisretorno.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/findata/resolver/engine.py` around lines 10 - 13, Update the “External providers” documentation wording to say providers are outside the library and networked, not client-side/networked. Clarify that REST credentials remain in the operator’s deployment, while preserving the existing injected async callback and provider ownership guidance.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/RESOLVER.md`:
- Around line 131-132: Update the “Cota esgotada” entry in RESOLVER.md to state
that HTTP 429 ends when the billing cycle renews or when the operator upgrades
the plan, preserving the existing renewal behavior and email-warning detail.
- Around line 101-102: The resolver documentation and provider contract are
inconsistent: the resolver replaces AssetClassification with provider results
rather than merging fields or lowering confidence. Update docs/RESOLVER.md lines
101-102 and the corresponding contract description in
src/findata/resolver/engine.py lines 14-15 to state that providers control
overrides and confidence, and that cascade entries are carried forward from
enriched.cascade; do not describe merge or confidence-reduction behavior unless
implementing it in the resolver.
---
Nitpick comments:
In `@src/findata/resolver/engine.py`:
- Around line 10-13: Update the “External providers” documentation wording to
say providers are outside the library and networked, not client-side/networked.
Clarify that REST credentials remain in the operator’s deployment, while
preserving the existing injected async callback and provider ownership guidance.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f2077952-8d8b-487b-8e78-2a2bb6092225
📒 Files selected for processing (4)
CHANGELOG.mddocs/RESOLVER.mddocs/SOURCES_WITH_AUTH.mdsrc/findata/resolver/engine.py
Address CodeRabbit feedback: providers replace the classification and own confidence/source; document HTTP 429 clears on cycle renewal or plan upgrade. Co-authored-by: Cursor <cursoragent@cursor.com>
Include plan-upgrade escape for Mais Retorno HTTP 429 and record the provider-replace wording alignment in the changelog. Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Summary
resolve_assetwith the public Free tier limits (500 credits/month, 1-year history, 15 req/s, HTTP 429 when exhausted).docs/SOURCES_WITH_AUTH.mdand points to dated public docs (maisretorno.com/mcp,developers.maisretorno.com, 2026-08-12).Test plan
bash scripts/ship/preflight.shon4c4de9f(ruff/mypy/pytest)git diff --checkReview evidence
4c4de9f. Cross-family attempt via Taskadversarial-reviewer(Cursor subagent). Label:EXTERNAL_SAME_FAMILYif same host pool, otherwise treat as external harness pass.AGENT_DATA(docs only; no MCP catalog/runtime change)origin/main4c4de9fPASSNO_FINDINGS— no secrets, no wiring, cascade remains stub-only; docs state operator-owned credentials and Free quota limits.NO_FINDINGS— docs-only clarification.Made with Cursor
Summary by CodeRabbit