You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: stop the Orkney and Broxbourne tests failing on the calendar and the network - #2341
The nightly Run Unit Tests job has failed on 12, 13 and 14 Nov (it was green until 11 Nov), and every open PR's unit-test check will now be red as well.
The cause is in a test I added in #2275, not in the product code. test_orkney_islands_council.py used hardcoded collection dates (21 Oct, 28 Oct, 11 Nov), and OrkneyIslandsCouncil correctly drops dates in the past. Once 11 Nov had passed, parse_data returned no bins and test_area_or_street_text_is_searched_and_first_address_looked_up failed (assert []).
It only surfaced now because the unit-test job used to ignore failures (fixed in #2273), so this is the gate doing its job, just 4 weeks after I wrote a time bomb into it.
Changes
Orkney: the fixture dates are now relative to today, and the test asserts the exact dates the scraper should return, rather than just that something is returned.
Reproduced: with the clock frozen at 2026-11-12, the old Orkney test fails (1 failed, 3 passed), matching the nightly.
With the clock frozen at 2026-11-12, the new test passes (4 passed). It also passes at 2027-03-01.
I checked every other test I wrote in October for the same flaw. Only Orkney's depends on "now", because it is the only scraper under test that filters past dates; the rest use relative dates or parse without filtering.
make unit-tests on Python 3.14.10 with Home Assistant installed: 499 passed. The 3 failures are the known sandbox-only tests that need real network access (test_check_postcode_valid/_invalid, test_create_webdriver_local), which pass in CI.
This PR changes no council file, so CI will also run the full live suite; treat any failures there as the usual state of the nation, not regressions from this PR.
Merge with a test: title. It isn't a releasable commit type, so the bump workflow will skip cleanly.
…work
The nightly unit-test job has failed since 12 Nov. The Orkney fixture used
hardcoded collection dates (21 Oct, 28 Oct, 11 Nov), and the scraper drops
dates in the past, so once 11 Nov passed parse_data returned no bins and
test_area_or_street_text_is_searched_and_first_address_looked_up failed. It
only surfaced now because the unit-test job used to ignore failures. The
fixture dates are now relative to today. Reproduced with the clock frozen at
2026-11-12 (old test fails, new passes), and the new test also passes at
2027-03-01.
The Broxbourne error tests called api.postcodes.io through check_postcode
(a pure parsing test depending on a third-party API being up), so they are
stubbed offline, as was done for Tower Hamlets.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015MaCS29izthZp2dwtvLwf4
No actionable comments were generated in the recent review.
Walkthrough
The Broxbourne test helper now stubs the postcode check. The Orkney tests now use dates relative to the current day and verify the expected collection dates.
Changes: Broxbourne test setup
Layer / File(s)
Summary
Stub the postcode check uk_bin_collection/tests/test_broxbourne_council.py
The test helper stubs check_postcode to return True and retains its existing browser-related mocks.
Orkney date tests
Layer / File(s)
Summary
Use relative collection dates uk_bin_collection/tests/test_orkney_islands_council.py
The tests create dates relative to the current day. The parsing test excludes the past collection and checks the remaining dates in ascending order. The search-flow test checks the exact expected dates.
This change only updates tests, so product behavior is unaffected. It makes the Orkney tests stable over time and removes the Broxbourne tests' dependency on a third-party postcode service. Merge risk is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names both affected test files and the two causes of failure: the calendar-dependent Orkney dates and the network-dependent Broxbourne postcode check. The raw summary shows the changes are t…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names both affected test files and the two causes of failure: the calendar-dependent Orkney dates and the network-dependent Broxbourne postcode check. The raw summary shows the changes are test-only updates that mock the postcode check and make Orkney dates relative to today. The title is specific to the main change, so it passes.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The nightly Run Unit Tests job has failed on 12, 13 and 14 Nov (it was green until 11 Nov), and every open PR's unit-test check will now be red as well.
The cause is in a test I added in #2275, not in the product code.
test_orkney_islands_council.pyused hardcoded collection dates (21 Oct, 28 Oct, 11 Nov), andOrkneyIslandsCouncilcorrectly drops dates in the past. Once 11 Nov had passed,parse_datareturned no bins andtest_area_or_street_text_is_searched_and_first_address_looked_upfailed (assert []).It only surfaced now because the unit-test job used to ignore failures (fixed in #2273), so this is the gate doing its job, just 4 weeks after I wrote a time bomb into it.
Changes
api.postcodes.iothroughcheck_postcode, so a pure parsing test depended on a third-party API being up. They now stub it, as was done for Tower Hamlets in ci/test: restore coverage above 80%, stop hiding unit-test failures, 4-session Selenium grid #2273.No product code changes.
Test plan
1 failed, 3 passed), matching the nightly.make unit-testson Python 3.14.10 with Home Assistant installed: 499 passed. The 3 failures are the known sandbox-only tests that need real network access (test_check_postcode_valid/_invalid,test_create_webdriver_local), which pass in CI.Merge with a
test:title. It isn't a releasable commit type, so the bump workflow will skip cleanly.Generated by Claude Code
Summary by CodeRabbit