Skip to content

refactor: use modern Go helpers - #71

Merged
rustatian merged 1 commit into
masterfrom
refactor/modern-go
Oct 6, 2026
Merged

rustatian merged 1 commit into
masterfrom
refactor/modern-go

Conversation

@rustatian

Copy link
Copy Markdown
Member

Reason for This PR

Use standard Go helpers for worker shutdown and timeout checks.

Description of Changes

  • Use sync.OnceFunc for watcher shutdown and the shared test cleanup.
  • Use t.Context() and maps.Keys in the worker spawn-timeout test.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

  • All commits in this PR are signed (git commit -s -S).
  • The reason for this PR is clearly provided.
  • The description of changes is clear and encompassing.
  • Any required documentation changes are included in this PR.
  • The change preserves the public API and behavior.
  • All added or changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 4, 2026 18:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.24%. Comparing base (43d99a7) to head (098484a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   77.13%   77.24%   +0.10%     
==========================================
  Files          20       20              
  Lines        1159     1160       +1     
==========================================
+ Hits          894      896       +2     
+ Misses        265      264       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rustatian rustatian self-assigned this Oct 6, 2026
@rustatian
rustatian merged commit 7eebe79 into master Oct 6, 2026
7 checks passed
@rustatian
rustatian deleted the refactor/modern-go branch October 6, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants