tests: exclude slow fuzz timeout regressions from per-PR CI - #2425
Open
ronaldtse wants to merge 1 commit into
Open
tests: exclude slow fuzz timeout regressions from per-PR CI#2425ronaldtse wants to merge 1 commit into
ronaldtse wants to merge 1 commit into
Conversation
The fuzz regression corpora for oss-fuzz issues #46208 (test_fuzz_keyring) and the timeout-9c10... case (test_fuzz_keyimport) together took ~5.5 minutes per CI leg, dominating the test suite. Split them into separate *_slow tests so they can be excluded from per-PR runs via 'ctest -E _slow$'. Per-PR workflows now pass -E '_slow$' to ctest. The slow tests remain registered and will run via default ctest invocations (nightly, manual dispatch, local full runs) so the regressions they guard don't bit-rot. Total rnp_tests runtime on macOS Botan drops from ~9.9 min to ~4.5 min with the exclusion; the 2 slow tests still pass when included.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
==========================================
- Coverage 85.37% 85.35% -0.03%
==========================================
Files 126 126
Lines 22789 22786 -3
==========================================
- Hits 19457 19448 -9
- Misses 3332 3338 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_fuzz_keyringandtest_fuzz_keyimportinto fast +*_slowvariants. The slow variants contain only the oss-fuzz timeout-regression corpora that take minutes to load.-E '_slow$'to every per-PRctestinvocation across all distro workflows so the slow tests are excluded from per-PR runs.ctest(nightly, manual dispatch, local full runs).Why
Profiled
rnp_testson macOS Botan: ~9.9 min total. Two tests dominated:test_fuzz_keyringtest_fuzz_keyimportBoth spend their time loading a single large oss-fuzz corpus file (
timeout-6140201111519232, 791 KB;timeout-9c10372fe9ebdcdb0b6e275d05f8af4f4e3d6051, 182 KB). These are regression guards against previously-fixed timeout bugs — they're valuable but shouldn't gate every PR.Excluding them drops per-PR
rnp_testsruntime to ~4.5 min on this machine. The slow tests still pass when included.Test plan
rnp_testslocally — both fast and slow variants passctest -N -E '_slow$'excludes exactly the two new_slowtests (285 → 283)ctest -N -R '_slow$'lists exactly the two new_slowtests (+ fixture)