Complete GraphQL::Schema::Visibility::Profile#preload - #5743
Merged
rmosolgo merged 1 commit intoSep 21, 2026
Merged
Conversation
Right now, we cannot freeze a GraphQL::Schema::Visibility::Profile object even after preloading because preloading is not complete. We would like to use preload + freeze in production because it will help us save memory by right-sizing hashes and allow the default_proc to be garbage collected.
Owner
|
Hey, thanks -- this is great. I totally forgot about this old TODO! I'm not sure what to make about these test failures. I don't recognize them, so I think they're legit, but I don't have a guess how they're related to this change 🤔 |
Contributor
Author
|
The tests are failing in the same way on master commit 4840991 |
Owner
|
Got it -- they were introduced in #5742. I'll take care of them separately. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, we cannot freeze a GraphQL::Schema::Visibility::Profile object even after preloading because preloading is not complete. We would like to use preload + freeze in production because it will help us save memory by right-sizing hashes and allow the default_proc to be garbage collected.