Run scalar partials without lazy resolvers - #5740
Merged
Merged
Conversation
Owner
|
Nice, thanks! Out of curiosity, how did you find this bug? Were you running a partial on a scalar in your app? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL::Execution::Runneronly initializes its lazy-value cache when the schema has configured lazy resolvers.Most calls to
Runner#lazy?are guarded byresolves_lazies, butrun_isolated_scalarcalls it unconditionally. As a result, running anExecution::Nextpartial for a scalar or enum path on a schema withoutlazy_resolveraises:This PR applies the same resolves_lazies guard used by the other call sites before checking the partial value. Schemas with lazy resolvers continue to resolve lazy scalar values, while schemas without them skip the unavailable cache.
It also adds regression coverage using a schema without configured lazy resolvers.