Skip to content

feat(bulls-and-cows): add PWA support - #71

Merged
gameroman merged 7 commits into
mainfrom
pwa-bulls-and-cows
Nov 8, 2026
Merged

gameroman merged 7 commits into
mainfrom
pwa-bulls-and-cows

Conversation

@gameroman

@gameroman gameroman commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • The app can be installed on supported devices and can load previously visited content while offline.
    • Added consistent app icons for browser tabs, home screens, and social sharing.
  • Bug Fixes
    • Updated Tailwind CSS packages to a newer version.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
2048 ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:47 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
simon-says ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:48 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bulls-and-cows ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:48 AM

@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3970b002-f2de-4451-8707-aec7963075c5
Commits

Reviewing files that changed from the base of the PR and between ac213a6 and ab437ae.

Files selected for processing: 1

  • apps/bulls-and-cows/astro.config.ts

No actionable comments were generated in the recent review.

Walkthrough

This pull request adds PWA setup to the Bulls and Cows app. It updates Astro and package configuration, adds related type references, and changes the layout to expose manifest and icon links and register the service worker.

Changes: PWA integration

Layer / File(s) Summary
PWA tooling and manifest
package.json, apps/bulls-and-cows/package.json, apps/bulls-and-cows/src/env.d.ts, apps/bulls-and-cows/astro.config.ts
The workspace catalog and app devDependencies now include the PWA-related packages. env.d.ts adds related type references and the #styles module declaration. astro.config.ts adds @vite-pwa/astro with manifest metadata and keeps the Solid integration.
Layout and page wiring
apps/bulls-and-cows/src/layouts/Layout.astro, apps/bulls-and-cows/src/pages/index.astro
Layout.astro removes the thumbnail prop, uses /icons/512x512.png for social metadata, replaces the shortcut icon link with fixed favicon and Apple touch icon links, conditionally adds the manifest link, and registers the service worker with immediate: true. index.astro stops creating and passing thumbnail.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Merge Risk: Minimal · previous review ac213

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat(bulls-and-cows): add PWA support" matches the main change in the changeset. The diff adds the Astro PWA integration, a web app manifest with 192x192 and 512x512 icons, the PWA packages…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat(bulls-and-cows): add PWA support" matches the main change in the changeset. The diff adds the Astro PWA integration, a web app manifest with 192x192 and 512x512 icons, the PWA packages in devDependencies and the catalog, and a manifest link plus service worker registration in Layout.astro. The title is concise, specific to the app, and follows a conventional commit style. The PR objectives also state the goal is to add PWA support to Bulls and Cows.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (4 skipped: 4 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 44e91274-0c7d-473d-9528-db8d5a369fa4
Commits

Reviewing files that changed from the base of the PR and between 8fa95c4 and ac213a6.

Files ignored due to path filters: 4

  • apps/bulls-and-cows/public/favicon.ico is excluded by !**/*.ico
  • apps/bulls-and-cows/public/icons/192x192.png is excluded by !**/*.png
  • apps/bulls-and-cows/public/icons/512x512.png is excluded by !**/*.png
  • bun.lock is excluded by !**/*.lock
Files selected for processing: 6

  • apps/bulls-and-cows/astro.config.ts
  • apps/bulls-and-cows/package.json
  • apps/bulls-and-cows/src/env.d.ts
  • apps/bulls-and-cows/src/layouts/Layout.astro
  • apps/bulls-and-cows/src/pages/index.astro
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
games ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:47 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
connect-four ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:48 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
water-sort-puzzle ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:48 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
pixel-puzzle-rush ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:48 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
wordle ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:47 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tetris ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:47 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nim ab437ae Commit Preview URL

Branch Preview URL
Nov 08 2026, 11:48 AM

@gameroman
gameroman marked this pull request as ready for review November 8, 2026 11:42
@gameroman
gameroman merged commit cf1abd1 into main Nov 8, 2026
12 checks passed
@gameroman
gameroman deleted the pwa-bulls-and-cows branch November 8, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant