Fix form submit bug and changelog link - #13
Open
RishiGoswami-code wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Title
Fix contact form submit crash and incorrect changelog link
Summary
This fix addresses a real runtime bug in the marketing contact forms and corrects the footer navigation for the changelog route.
Issue Solved:
#12
Changes made
FormDataconversion in the sales and engineer contact forms.formData.entries().toArray()withArray.from(formData.entries())to ensure the form data is converted correctly./blog/to/changelog/.Files changed
src/components/marketing/talk-to-an-engineer/form.tsxsrc/components/marketing/sales/form.tsxsrc/components/Footer.jsxWhy this was needed
The contact forms were throwing at submit time because
FormData.entries()does not support.toArray(). This caused the lead capture flow to break. The changelog link was also routing to the wrong section.