Repository navigation
Conversation
scikit-build-core/CMake build of libfinufft.so, loaded via ctypes (hence the py3-none ABI tag despite being a genuine per-platform compiled artifact, confirmed from the published x86_64 wheel's contents). FFTW is fetched and built from source by CMake, no external riscv64-missing dependency. Overrides FINUFFT_ARCH_FLAGS to empty on riscv64 (upstream hardcodes -march=x86-64 in pyproject.toml for all platforms otherwise). Adds a licence patch: upstream declares no license-files, so the wheel ships neither its own LICENSE nor FFTW's (GPL-2.0-or-later, statically linked).
Upstream's pyproject.toml pins tool.cibuildwheel.linux.musllinux-x86_64-image to the "musllinux_1_1" alias, which cibuildwheel 4.x no longer resolves. cibuildwheel validates that value at config-load time regardless of the selected CIBW_ARCHS/CIBW_BUILD, so the riscv64-only, manylinux-only build failed before even starting. Override it to a supported alias.
…clash
{project} is the finufft checkout root and {package} is python/finufft, so
before-build copied LICENSE from a path above the container root and
staged both licence files next to the wrong pyproject.toml. Stage them in
{package}, where the patched license-files glob looks.
Drop the CIBW_TEST_COMMAND/CIBW_TEST_REQUIRES overrides: upstream's own
[tool.cibuildwheel] already runs pytest {project}/python/finufft/test,
while the override pointed at the C++ test/ directory.
pyproject-metadata rejects an SPDX project.license combined with a
"License ::" classifier, so the patch now drops that classifier too.
…ndency Upstream's build-system.requires pins cmake (>= 3.19, < 4), and no riscv64 cmake wheel exists below 4.x, so pip compiles CMake 3.31 from its sdist. That bootstrap's cmcurl needs OpenSSL's development headers, which the manylinux_riscv64 image does not ship (gotcha 608).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finufft2.5.1Compiles
libfinufft.so(non-uniform FFT library), loaded via ctypes rather than the CPython C-API, hence thepy3-noneABI tag despite being a genuine per-platform compiled build - confirmed from the published x86_64 wheel's contents (finufft/libfinufft.so+ statically-built FFTW libs). Upstream publishes no riscv64 wheel.Mirrors the Linux leg of upstream's
build_finufft_wheels.yml(package-dir: python/finufft).Differs from upstream
FINUFFT_ARCH_FLAGSto empty - upstream'spyproject.tomlhardcodes-march=x86-64for every platform via its ownconfig-settingsopenssl-develinbefore-all- upstream pinscmake<4, which has no riscv64 wheel, so pip compiles CMake 3.x from source and its bootstrap needs OpenSSL headersMatrix: single py3-none build (
wheel.py-api = "py3"collapses the matrix)Testing
pytest {project}/python/finufft/test, inherited from upstream's own[tool.cibuildwheel])License: Wheel bundles FFTW (GPL-2.0-or-later), statically linked and built from source; upstream ships no licence text for it or for its own LICENSE, so the build adds both.
Patches
0001-license-files.patch- Inappropriate (licensing gap, not riscv64-specific). Declareslicense = "Apache-2.0"+license-filesso the wheel ships LICENSE + FFTW's LICENSE.fftw, and drops theLicense ::classifier that pyproject-metadata rejects alongside an SPDX licence.Built on cp312; CI pending.