Repository navigation
Conversation
luhenry
added a commit
that referenced
this pull request
Oct 14, 2026
…, dedupe -> ci-running (#3162)
luhenry
marked this pull request as draft
October 14, 2026 11:32
cibuildwheel extracts a .tar.gz package-dir to its own temp directory and chdirs the whole build into it, so CIBW_TEST_SOURCES (resolved against the new cwd) never saw the tests/ staged at the checkout root; the job built and installed the wheel fine and only failed ~34 minutes in, in testing, with "cibuildwheel: Test source tests does not exist." Extracting the sdist ourselves and pointing package-dir at the resulting directory keeps the build rooted where the rest of the job expects it.
The riscv64 build job failed in the 'Verify wheel contents' step for every leg, all 2 hours in: scripts/verify_wheel.py's _require_filename_tag compares the wheel filename's platform segment against WHEEL's Tag: lines as one string, but auditwheel repairs a riscv64 wheel to the compressed tag set manylinux_2_34_riscv64.manylinux_2_39_riscv64 (its policy floor sits below the manylinux_2_39 build image), which WHEEL still lists as two separate Tag: lines. Neither side is wrong; the comparison is (gotcha 510 in the porting skill's references). Patches scripts/verify_wheel.py (checked out fresh from reflex-dev/xy, not carried in our sdist) to split the filename's platform segment on '.' and check each resulting tag individually, which keeps the single-tag case unchanged. Verified against the actual failing filename/WHEEL-tags pair from run 38733621391, plus the single-tag and genuinely-missing-tag cases, with the patched function imported directly.
The riscv64 job failed in cibuildwheel's test-requires install: pillow 13.0.0 and numpy 2.5.4 are on PyPI as sdists with no riscv64 wheel, and pip resolves to the newest version across both indexes, so it took them over the registry's pillow 12.3.0 / numpy 2.5.3 wheels and built them from source. numpy compiled (19 minutes for cp312 alone); pillow died on missing libjpeg headers. PIP_ONLY_BINARY=numpy,pillow in CIBW_TEST_ENVIRONMENT makes pip stop at the newest registry wheel instead (gotcha 210).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xy0.0.8Compiles the Rust
xy_corecdylib that the Python package loads through ctypes, so onepy3-nonewheel serves every interpreter. Upstream publishes no riscv64 wheel.Mirrors upstream's
build_release_artifacts.yml.Differs from upstream
Testing
verify_wheel.py --expect-nativeand native-backend import check, as in its release workflowtests/covering the kernels and exporters; the rest need Chromium, Node or repo scriptsreflexextra not installed in the smoke - not needed to exercise the coreLicense: OK
Locally on x86_64 from the same sdist: 727 passed, 3 skipped.