Repository navigation
fix(githubactions): fetch a fresh ID token on every call - #19
Merged
Merged
Conversation
The provider cached tokens until shortly before expiry, so an early rfc7523 refresh could re-send a token whose jti was already exchanged. Anthropic WIF rejects that as a replay.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation and tests correctly enforce fresh token retrieval.
Review effort: Balanced
Findings: None
What changed in this PR
Removes GitHub Actions ID-token caching to prevent replay rejection during RFC 7523 exchanges.
Changes:
- Fetches a fresh ID token on every call.
- Removes cache synchronization and updates tests.
| File | Description |
|---|---|
pkg/token/githubactions/githubactions.go |
Removes token caching and locking. |
pkg/token/githubactions/githubactions_test.go |
Verifies consecutive calls fetch distinct tokens. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
baluchicken
approved these changes
Sep 30, 2026
bonifaido
enabled auto-merge (squash)
October 1, 2026 07:05
stoader
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub Actions provider cached ID tokens until shortly before expiry, so an early rfc7523 refresh could re-send a token whose jti was already exchanged, which Anthropic WIF rejects as a replay (the same issue platform fixed for JWT-SVIDs in riptideslabs/platform#159). It now fetches a new token on every call, which also removes the lock.