Repository navigation
feat(conjur): add CyberArk Conjur provider - #15
Merged
Merged
Conversation
Logs in with Conjur's JWT authenticator and reads the configured variables in one batch request, polling for rotated values. Adds a generic credential.Secret type; VaultSecret is now an alias for it so both providers return the same key/value result.
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Address zero-expiry token handling and qualified Conjur variable ID normalization.
Review effort: Lite
Findings: None
What changed in this PR
Adds a CyberArk Conjur provider with JWT authentication, batched secret retrieval, rotation polling, TLS support, and shared secret typing.
Changes:
- Adds Conjur configuration, authentication, retrieval, polling, telemetry, and tests.
- Introduces
credential.Secretwith backward-compatibleVaultSecretalias. - Documents Conjur usage in the README.
| File | Description |
|---|---|
README.md |
Documents Conjur usage and configuration. |
pkg/credential/result.go |
Adds the shared Secret type. |
pkg/credential/equal.go |
Updates secret equality handling. |
pkg/conjur/telemetry.go |
Defines Conjur telemetry attributes. |
pkg/conjur/option.go |
Adds Conjur configuration options. |
pkg/conjur/creds.go |
Implements authentication, retrieval, polling, and TLS support. |
pkg/conjur/conjur_test.go |
Tests Conjur provider behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bonifaido
marked this pull request as ready for review
September 28, 2026 10:52
stoader
approved these changes
Sep 28, 2026
baluchicken
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
conjurprovider for CyberArk Conjur (Secrets Manager Self-Hosted and SaaS). It exchanges the identity JWT for a Conjur access token through the JWT authenticator. Then it reads the configured variables in one batch request, so a rotated pair is never returned half updated, and polls for rotated values. The constructor takes a TLS config for self-hosted instances behind a private CA.credential.VaultSecretis now an alias of a new genericcredential.Secret, so Conjur results reuse the control plane's existing Vault typing. Existing consumers compile unchanged.https://docs.cyberark.com/secrets-manager-sh/latest/en/content/developer/conjur-api-go.html