-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add update/update_async for renaming a segment #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dielduarte
merged 4 commits into
main
from
feature/dev-1205-edit-segments-through-the-api
Aug 26, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0d54001
feat: add update/update_async for renaming a segment
dielduarte 7001d32
test: add async coverage for Segments.update_async
dielduarte 9bbdd65
fix: update segment response no longer includes name
dielduarte 74119a9
test: drop 'should' from the update_async test name
dielduarte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import pytest | ||
|
|
||
| import resend | ||
| from resend.exceptions import NoContentError | ||
| from tests.conftest import AsyncResendBaseTest | ||
|
|
||
| # flake8: noqa | ||
|
|
||
| pytestmark = pytest.mark.asyncio | ||
|
|
||
|
|
||
| class TestResendSegmentsAsync(AsyncResendBaseTest): | ||
| async def test_segments_update_async(self) -> None: | ||
| self.set_mock_json( | ||
| { | ||
| "object": "segment", | ||
| "id": "78261eea-8f8b-4381-83c6-79fa7120f1cf", | ||
| } | ||
| ) | ||
|
|
||
| params: resend.Segments.UpdateParams = { | ||
| "name": "Renamed Segment", | ||
| } | ||
| segment = await resend.Segments.update_async( | ||
| id="78261eea-8f8b-4381-83c6-79fa7120f1cf", params=params | ||
| ) | ||
| assert segment["object"] == "segment" | ||
| assert segment["id"] == "78261eea-8f8b-4381-83c6-79fa7120f1cf" | ||
|
|
||
| async def test_update_segments_async_raises_exception_when_no_content( | ||
| self, | ||
| ) -> None: | ||
| self.set_mock_json(None) | ||
| params: resend.Segments.UpdateParams = { | ||
| "name": "Renamed Segment", | ||
| } | ||
| with pytest.raises(NoContentError): | ||
| _ = await resend.Segments.update_async( | ||
| id="78261eea-8f8b-4381-83c6-79fa7120f1cf", params=params | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.