feat(webhooks): add event listing endpoints - #268
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a03a23-f8ee-77c9-979a-7352f2a6819b Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adds new public sync and async methods for webhook event listing and retrieval, expanding the SDK's API surface and external contract.
Re-trigger cubic
dielduarte
left a comment
There was a problem hiding this comment.
some findings from the pr-preview skill, behavior wise is all working, already approving.
WebhookEventSummary.type and GetEventResponse.type (_webhooks.py:38,50) are typed str, but resend.WebhookEvent (a Literal of event names) already exists and is exported , worth reusing here, matching what resend-node#1083 did. Also: the new params/response TypedDicts have no field docstrings (every sibling does), and examples/webhooks.py wasn't extended with the three new methods
Adds sync and async methods for listing webhook events, retrieving an event, and listing delivery attempts. Includes endpoint-specific response types and pagination parameters.
Linear: https://linear.app/resend/issue/DEV-1926
Tests: targeted webhook tests, lint, mypy, and live API calls.