Skip to content

Group the semantic diff comment's changelog entries as the changelog does - #9007

Merged
cknitt merged 1 commit into
masterfrom
semantic-diff-changelog-groups
Oct 24, 2026
Merged

cknitt merged 1 commit into
masterfrom
semantic-diff-changelog-groups

Conversation

@cknitt

@cknitt cknitt commented Oct 24, 2026

Copy link
Copy Markdown
Member

Follow-up to #9002: the comment's Changelog section groups the entries under the changelog's own category headings (scripts/changelogFragments.js's categories), in its order, instead of a flat list led by each category's emoji. #8950's entries, rendered locally:

Changelog

🚀 New Feature

  • Add @instanceOf("Class") and @typeOf("…") for abstract types …

🐛 Bug fix

  • An untagged variant with both Blob and File cases matches files as File …

🏠 Internal

  • Untagged variants recognize stdlib classes only through their @instanceOf annotations …

A fragment that doesn't parse goes under #### :grey_question: Not a changelog fragment with its file name. The budget cap from #9002 counts the headings too.

Tests: the grouping, with two fragments of one category under one heading.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp

A flat list led by emojis read unlike the changelog the entries end up
in. The entries are now grouped under the changelog's category headings,
in its order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt cknitt added the changelog:skip No release notes needed label Oct 24, 2026
@github-actions

Copy link
Copy Markdown

Changelog

No changelog entry.

Semantic Diff

1 commit · Full page

Group the comment's changelog entries as the changelog does

8de4c2e · cknitt + Claude · Oct 24, 2026, 05:47 UTC

A flat list led by emojis read unlike the changelog the entries end up in. The entries are now grouped under the changelog's category headings, in its order.

@cknitt

cknitt commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

@codex review

@cknitt
cknitt marked this pull request as ready for review October 24, 2026 05:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T05:50:13.585542Z 8de4c2e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 8de4c2e0d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cknitt
cknitt requested a review from fhammerschmidt October 24, 2026 05:50
@pkg-pr-new

pkg-pr-new Bot commented Oct 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9007

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9007

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9007

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9007

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9007

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9007

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9007

commit: 8de4c2e

@github-actions

Copy link
Copy Markdown

@cknitt
cknitt enabled auto-merge (squash) October 24, 2026 06:11
@cknitt
cknitt merged commit e6b89eb into master Oct 24, 2026
26 of 27 checks passed
@cknitt
cknitt deleted the semantic-diff-changelog-groups branch October 24, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip No release notes needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants