Skip to content

Render the semantic diff with the workflow's own scripts - #8963

Merged
cknitt merged 1 commit into
masterfrom
semantic-diff-merge-checkout
Oct 22, 2026
Merged

cknitt merged 1 commit into
masterfrom
semantic-diff-merge-checkout

Conversation

@cknitt

@cknitt cknitt commented Oct 22, 2026

Copy link
Copy Markdown
Member

For a pull_request event, GitHub runs the workflow file of the pull request's test merge into master, but the Semantic Diff workflow checked out its scripts from the pull request's head. A branch made before #8958 therefore ran master's workflow, which passes --markdown, --url and --since, against its old commitRecords.js, which read --markdown as a revision:

Error: Command failed: git show -s --format=%h --abbrev=9 --markdown

This failed the latest runs on the #8951 stack (#8950, #8948, #8949).

The checkout now takes github.sha, the merge commit the workflow itself comes from, so the workflow and the scripts always match: master's tooling plus whatever the pull request changes in it. The rendered commits are unchanged, since the renderer reads them through the pr-<N> ref. Fork pull requests (pull_request_target) keep checking out the base branch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp

@cknitt cknitt added the changelog:skip No release notes needed label Oct 22, 2026
@github-actions

Copy link
Copy Markdown

Semantic Diff

1 commit · Full page

Render the semantic diff with the workflow's own scripts

2abf182 · Christoph Knittel with Claude Opus 5.5 · Oct 22, 2026

A pull request's run takes the workflow from its merge into master but checked out the renderer from the branch, so a branch made before #8958 passed --markdown to a commitRecords.js that took it for a revision. The renderer now comes from the merge as well.

@cknitt
cknitt marked this pull request as ready for review October 22, 2026 18:07
A pull request's run takes the workflow from its merge into master but
checked out the renderer from the branch, so a branch made before #8958
passed --markdown to a commitRecords.js that took it for a revision. The
renderer now comes from the merge as well.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt
cknitt force-pushed the semantic-diff-merge-checkout branch from 2abf182 to d1edaff Compare October 22, 2026 18:08
@github-actions

Copy link
Copy Markdown

Semantic Diff

1 commit · Full page

Render the semantic diff with the workflow's own scripts

d1edaff · Christoph Knittel with Claude Opus 5.5 · Oct 22, 2026

A pull request's run takes the workflow from its merge into master but checked out the renderer from the branch, so a branch made before #8958 passed --markdown to a commitRecords.js that took it for a revision. The renderer now comes from the merge as well.

@pkg-pr-new

pkg-pr-new Bot commented Oct 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8963

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8963

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8963

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8963

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8963

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8963

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8963

commit: d1edaff

@github-actions

Copy link
Copy Markdown

@cknitt
cknitt merged commit 5de48e6 into master Oct 22, 2026
26 checks passed
aspeddro pushed a commit to aspeddro/rescript-compiler that referenced this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip No release notes needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants