Skip to content

Upgrade react and react-dom to v19 and adapt gentype#8501

Merged
cknitt merged 1 commit into
masterfrom
react-19
Jul 9, 2026
Merged

Upgrade react and react-dom to v19 and adapt gentype#8501
cknitt merged 1 commit into
masterfrom
react-19

Conversation

@cknitt

@cknitt cknitt commented Jul 9, 2026

Copy link
Copy Markdown
Member

For React 19 typedefs, React.JSX.Element needs to be used in place of JSX.Element (which was already deprecated in React 18).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10798875c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread compiler/gentype/emit_type.ml
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.69%. Comparing base (27147f0) to head (79b3e53).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8501   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files         457      457           
  Lines       62123    62123           
=======================================
  Hits        46400    46400           
  Misses      15723    15723           
Files with missing lines Coverage Δ
compiler/gentype/emit_type.ml 91.48% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8501

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8501

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8501

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8501

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8501

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8501

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8501

commit: 79b3e53

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

@cknitt cknitt merged commit d6c4bc8 into master Jul 9, 2026
30 checks passed
@cknitt cknitt deleted the react-19 branch July 9, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants