Repository navigation
Conversation
Flatten deployment and OCI package exports into derivations, preserve top-level module access, and collect all CI failures instead of cancelling at the first error. Assisted-by: Replit
ryantm
force-pushed
the
fix-nixci-builds
branch
from
October 22, 2026 23:09
48f84b7 to
2760a5c
Compare
Keep image artifacts out of Nix outputs and binary caches. Convert disk, tarball, and OCI outputs into runtime builders, and exercise them with temporary fixtures including destination safety and cleanup checks. Assisted-by: Replit
Coerce path-valued builder environment inputs into store files instead of discarding their dependency context with toString. Assisted-by: Replit
Create and verify a hardlink at test runtime, and only require cached closure inputs to retain links that still exist in the source. Assisted-by: Replit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The package output set contains nested deployment and OCI maps. CI discovers flattened dotted names, then attempts to build those names as literal package attributes; the attributes do not exist. Fail-fast cancellation prevents a complete inventory of other build failures.
What changed
This draft is the starting point for full-suite triage. Existing aliases and supported runtime versions are unchanged. Further straightforward build fixes will be added after the hosted suite runs; runtime retirement decisions require separate agreement.
Test plan
Failure triage
The first full run recorded 14 failed attempts across seven output attributes. Thirteen attempts failed through libarchive's test_option_c; one initial Node 23-alias attempt failed SQLite's tests before its retry hit libarchive. These are dependencies of the same Node 24 build, not independent obsolete runtimes. Eleven bundle/OCI outputs remained queued behind dependencies.
Rebased onto the merged Node dependency fix in #505. It retains Node 24.22.1 while removing the failing dependency pin. Node 23 already aliases Node 24; no supported implementations or compatibility aliases were removed.
Rollout
No publishing or repository-setting changes. Reverting restores the previous package export shape and default fail-fast behavior. Keep this PR in draft until package failures have been investigated.
Local image builders
All exported disk, tarball, full-bundle OCI, and per-module OCI outputs now build executable scripts rather than image artifacts. NixCI builds these scripts and their dependencies; image bytes are written only when a user invokes nix run with a local output directory. The fixture check creates small temporary images and retains only its result marker. No runtime versions or aliases were removed.
Examples:
Callers that previously copied artifacts from nix build results must migrate to nix run. The copy helper now takes the local image directory as its first argument. Builders reject existing destinations and Nix-store paths, clean temporary and partial output on failure, and support paths containing spaces.
Validation covers temporary SquashFS metadata, tarball contents, per-module OCI metadata/blobs, full-bundle OCI invariants and digest-preserving copying, overwrite/store-path/symlink rejection, and failure cleanup. The full local check suite passed on this revision, including the image fixtures in paths containing spaces; hosted CI also passed.
Final validation
Validated commit d5dc78c:
~ written by ⠕ Replit