Repository navigation
feat(config): reject an owner-prefixed deployment.name and add --validate-config - #49
Merged
Merged
Conversation
…date-config A name such as replicate/foo made the deployment path replicate/replicate/foo, which 404s at the Push step.
lucataco
force-pushed
the
lcatacora/validate-deployment-name
branch
from
November 5, 2026 18:56
0d20458 to
a5e5d59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three configs set
deployment.name: replicate/<name>together withdeployment.owner: replicate. cog-safe-push then buildsreplicate/replicate/<name>, which 404s at the Push step of full deploys only. One of them failed every full deploy for months without anyone noticing.Reject the config when it loads, and let CI validate configs without pushing.
What changed
DeploymentConfig.namenow rejects a value that contains/. The error tells you whichdeployment.owneranddeployment.nameto set. It does not strip the prefix.--validate-configflag. It loads the config, applies CLI overrides, prints one OK line, and exits 0. An invalid config exits 1 with the error.Scope
deployment.nameonly. Other config fields are unchanged.--validate-configneeds noREPLICATE_API_TOKEN, cog, or network.Blast Radius
CI installs cog-safe-push from git main. After merge, any config with an owner-prefixed name fails at load on its next deploy. Known affected configs: replicate/cog-bytedance-proxy
seedance-1.5-pro.yaml, replicate/cog-clarity-proxycrystal-video-upscaler.yamlandphilz1337x-crystal-upscaler.yaml. Those deploys already fail today at Push, and fix PRs are being opened separately.Verification
script/unit-test: 141 passed.script/lint: ruff and pyright clean.--validate-configexit codes with no token and sockets blocked.--validate-configon everymodels/*/cog-safe-push-configs/*.yaml. Onlyseedance-1.5-pro.yamlfails on the new rule.seedance-1-pro.yamlpasses.