Use PULP3_* env vars for Hosted Pulp credentials [RHELDST-45461] - #720
Open
crungehottman wants to merge 1 commit into
Open
crungehottman wants to merge 1 commit into
crungehottman wants to merge 1 commit into
Conversation
Update KonfluxSource to read hosted pulp credentials from PULP3_* environment variables instead of PUSHSOURCE_KONFLUX_PULP_* variants. This aligns with pubtools-pulp's Pulp3ClientService, which reads from the same PULP3_* env vars. Since both pushsource and pubtools-pulp connect to the same hosted pulp instance with the same credentials, sharing one set of env vars eliminates duplication in the Tekton task configuration.
crungehottman
requested review from
chandwanitulsi,
rajulkumar and
rbikar
as code owners
September 23, 2026 14:42
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 59
Lines 2736 2736
=========================================
Hits 2736 2736
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update KonfluxSource to read hosted pulp credentials from PULP3_* environment variables instead of PUSHSOURCE_KONFLUX_PULP_* variants.
This aligns with pubtools-pulp's Pulp3ClientService, which reads from the same PULP3_* env vars. Since both pushsource and pubtools-pulp connect to the same hosted pulp instance with the same credentials, sharing one set of env vars eliminates duplication in the Tekton task configuration.