Skip to content

Apply all message filters to grouped triage - #416

Open
maximelb wants to merge 1 commit into
masterfrom
fbH/group-filters
Open

maximelb wants to merge 1 commit into
masterfrom
fbH/group-filters

Conversation

@maximelb

@maximelb maximelb commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Grouped triage accepts the same filters as the message list. The SDK shares parameter encoding and search validation between both views, and the CLI exposes mailbox, sender, campaign, IOC, placement, direction, score, lane and literal-search options alongside the existing filters.

One recipient copy must match every active filter. Help explains newest-matching-copy order, continuation through short or empty pages, and that group summaries and actions still cover all copies. Exact matching-copy counts are omitted when they exceed the bounded query budget.

Validation: 4,739 local tests pass (five pre-existing skips); Python 3.10–3.14 CI passes; wire-parameter parity and CLI forwarding coverage, including negative search validation. Risk: this interface must follow deployment of complete server-side group filtering. The grouped-triage prerequisite has merged; this PR targets master. Maxime merges this public PR.

🤖 Generated with Claude Code

@maximelb

maximelb commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

/lc-review

lcbill
lcbill previously approved these changes Oct 1, 2026
Base automatically changed from fbC/mail-groups to master October 1, 2026 23:56
@maximelb
maximelb dismissed lcbill’s stale review October 1, 2026 23:56

The base branch was changed.

@maximelb

maximelb commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

/lc-review

@maximelb

maximelb commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

/lc-review

@limacharlie-refractionpoint

Copy link
Copy Markdown

LimaCharlie Cloud Security — code scan

No new code findings were introduced by this pull request.

This check reports and never fails: no gating.fail_on is set on the code_scanning policy.

Scanned refractionPOINT/python-limacharlie 61d5722…a2d3ce4 — only findings new in the head commit are listed; anything already on the base branch is the repository's own finding set, on the Cloud Security Code page.

This comment is updated in place on every push to this pull request.

@maximelb

maximelb commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

The automated /lc-review has not returned substantive feedback after more than30 minutes from the first request. Adversarial self-review found no open issues: repeated/false/zero values retain their wire meaning, both views share literal-search validation, the message disposition API is preserved, and group paging/action scope is documented. All exact-head CI is green, including Python3.10–3.14 and distribution/integration checks; full local suite4739 passes with five pre-existing skips. This public PR remains for Maxime to merge after the server contract is deployed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants