Expose caller authorization for extension requests - #415
Merged
Merged
Conversation
lcbill
approved these changes
Oct 1, 2026
Contributor
Author
|
/lc-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some extension actions require the authenticated caller's permissions, but the generic CLI request command could not select the SDK's existing caller authorization path. Add explicit
extension request --impersonateforwarding; requests continue to omit caller identity unless selected. Help and the CLI reference explain the flag.Validation: all 4,664 unit and microbenchmark correctness tests pass (5 existing skips). Actual Click invocation tests cover both default and selected behavior through the real SDK request builder; disabling forwarding fails the selected authorization assertion while the default control still passes. An authenticated action requiring caller identity refused the default request and accepted the flagged request.
Risk: selecting the flag intentionally sends the current caller identity through the existing authenticated SDK path; it grants no additional permissions. No token is printed or persisted by this change. Live check: invoke a caller-authorized action with and without the flag and verify only the flagged request supplies the existing identity; unexpected permissions or identity forwarding by default falsify the change.
🤖 Generated with Claude Code