Email Security dispositions, release and resumable report remediation - #413
Merged
Merged
Conversation
Contributor
Author
|
/lc-review |
lcbill
previously approved these changes
Sep 30, 2026
Contributor
Author
|
/lc-review |
lcbill
previously approved these changes
Oct 1, 2026
maximelb
changed the title
Contributor
Author
|
/lc-review |
Contributor
Author
|
Adversarial follow-up review completed: required UUID group attempts, frozen request preservation across preview/confirm/polling, bounded waiting and timeout results, unknown/partial outcome refusal, permissions and original-only classification are covered by the corresponding unit tests and documented workflow. Command flags/signatures and public links were checked. Exact current-head CI passes. A fresh /lc-review was requested, but no substantive new AI review has arrived after more than 40 minutes. Empty approval bodies are not content reviews. This public PR remains open for Maxime; documentation publication must follow the corresponding stable SDK/CLI release. |
lcbill
previously approved these changes
Oct 1, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maximelb
force-pushed
the
fbB/disposition-reports
branch
from
October 1, 2026 23:38
bff1d76 to
6932f8d
Compare
lcbill
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add independent analyst dispositions, report resolution with preview/confirmation, and release_message to the Email Security SDK and CLI. Dispositions preserve the engine verdict. Report remediation supports message, campaign and a frozen same-message group; group requests use an explicit UUID attempt.
The report resolve command accepts --attempt, --wait and a bounded --timeout. The SDK waiter repeats the unchanged request, returns prepared confirmation without executing it, and resumes confirmed durable work after a timeout. Timeouts retain the job and CLI exit status 2; incomplete or unknown outcomes are refused.
Risk: these APIs require the corresponding service release. Group actions continue after client interruption; resume with the same attempt and confirmation. Resolving a group report classifies only its linked original.
Validation: full unit/microbenchmark suite passed (4681 tests, six pre-existing skips), then 138 focused tests passed after adding resumed-preview confirmation cases. Command discovery and --ai-help checked. After deployment, preview and confirm a synthetic group report and verify bounded waiting, original-only disposition and unchanged verdict.
🤖 Generated with Claude Code