Fix enum and const validation for nested boolean values - #1323
Merged
datho7561 merged 1 commit intoAug 13, 2026
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
datho7561
approved these changes
Aug 13, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good and fixes the specific case you mentioned. Thanks, Morgan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
getNodeValue()to return the parsed value for boolean nodes instead of their raw YAML sourcePreviously, booleans nested inside object or array
enum/constvalues were reconstructed as strings. For example, the YAML value:was compared as
{ "required": "true" }against the schema value{ "required": true }. This caused the diagnosticValue is not accepted. Valid values: {"required":true}..What issues does this PR fix or reference?
Fixes #1320
Is it tested? How?
getNodeValue()reads raw source text for booleans, breakingconst/enumvalidation (e.g.enum: [true]rejects a validtrue) #1320 (comment)