Fix tests - #1158
Merged
Merged
Conversation
datho7561
force-pushed
the
fix-tests
branch
2 times, most recently
from
July 30, 2026 18:59
cc758c1 to
eda4039
Compare
shin19991207
requested changes
Jul 30, 2026
shin19991207
left a comment
shin19991207
left a comment
Member
There was a problem hiding this comment.
I think we should update CI and release to Node 22? @vscode/test-electron@3.1.0 package declares node >=22 (https://github.com/microsoft/vscode-test/blob/003b260c457c1d037a564b4c730624ac45b7789a/package.json#L21-L24).
- https://github.com/datho7561/vscode-xml/blob/eda403996ae70a7131b410a4ffc858eae230df3e/.github/workflows/ci.yaml#L11
- https://github.com/datho7561/vscode-xml/blob/eda403996ae70a7131b410a4ffc858eae230df3e/.github/workflows/release.yml#L86
- https://github.com/datho7561/vscode-xml/blob/eda403996ae70a7131b410a4ffc858eae230df3e/.github/workflows/release.yml#L191
Member
|
There's another Node version 20 that's used here: https://github.com/datho7561/vscode-xml/blob/1b775300ee512fe159fbc6fd9fc966f278938e03/.github/workflows/release.yml#L86 |
Contributor
Author
|
Good catch, thanks! |
shin19991207
approved these changes
Jul 31, 2026
shin19991207
left a comment
shin19991207
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thanks, David!
- Add tsconfig so that we don't type check libraries (this wastes time and sometimes yields false positives). - Bump setup-graalvm to get windows build working There's a weird bug related to MSVC not being set up properly that should be fixed by a newer version of the action. - Upgrade testing framework (@vscode/test-electron and @vscode/test-cli) to latest version to address a failure on macOS - Use Node 22 in CI, since the test framework requires it Signed-off-by: David Thompson <davthomp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.