Repository navigation
Remove Redundant Type Hierarchy #4560
Description
Describe the bug
Currently, when you right click a class name, there are two context menu entries called "Show Type Hierarchy".
One is contributed by us (vscode-java) and one is a default one provided by VS Code.
We should remove the entry provided by us, along with all the associated UI code, since the default type hierarchy UI provided by VS Code is sufficient, and removing code with reduce the complexity of this project. VS Code provides this UI automatically, since jdtls advertises it supports type hierarchy. The other entry exists because we implemented type hierarchy support before it was added into the LSP specification.
There is one minor difference between our custom type hierarchy UI and the default UI: we provide a "Class Hierarchy" view that shows both super classes and sub classes at the same time. However, after talking this through with Rob, I don't think it's worth saving this UI, since then there would be two different ways to access the same information, which would be confusing to end users.
Here's a list of things we'll need to remove: (hopefully complete but there might be other things as well):
- The UI itself, i.e.
typeHierarchyTree.ts - The typings we have for interacting with VS Code's references view API (
references-view.d.ts) - The commands to open the type hierarchy view (these are registered in package.json and implemented throughout the codebase; grepping for the id listed in the package.json should find the implementations)
- The registration of various commands (also in the package.json)
- There's separate "Subtype hierarchy" and "Supertype hierarchy" commands that are referenced in code, but only appear in the command palette and currently don't seem to function. These should be removed
See #2376 for some more context
To Reproduce
Steps to reproduce the behaviour:
- Make a type that inherits from a few other types:
public class B extends A implements Serializable {
}- Right click on the type name (in this case
B). - There are two "Show Type Hierarchy"
Expected behaviour
There should instead be one "Show Type Hierarchy" entry
Environment
- Operating System: Linux (but it's not Linux specific)
- JDK version: 25
- Visual Studio Code version: 1.143.1
- Java extension version: 1.59.0
Additional Information
Activity