Skip to content

Fix audit and lint issues #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redanthrax merged 1 commit into from
Aug 10, 2026
Merged

Fix audit and lint issues #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nodes/HaloPSA/HaloPsa.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ export class HaloPsa implements INodeType {
description: INodeTypeDescription = {
displayName: 'HaloPSA Complete',
name: 'haloPsa',
icon: 'file:halopsa.svg',
icon: {
light: 'file:halopsa.svg',
dark: 'file:halopsa.dark.svg',
},
group: ['transform'],
version: 1,
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
Expand Down
8 changes: 7 additions & 1 deletion nodes/HaloPSA/HaloPsaTrigger.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ export class HaloPsaTrigger implements INodeType {
description: INodeTypeDescription = {
displayName: 'HaloPSA Trigger',
name: 'haloPsaTrigger',
icon: 'file:halopsa.svg',
icon: {
light: 'file:halopsa.svg',
dark: 'file:halopsa.dark.svg',
},
group: ['trigger'],
version: 1,
subtitle: '={{$parameter["event"]}}',
Expand Down Expand Up @@ -227,6 +230,7 @@ export class HaloPsaTrigger implements INodeType {

return false;
} catch (error) {
console.error('Failed to check existing HaloPSA webhook', error);
return false;
}
},
Expand Down Expand Up @@ -320,6 +324,7 @@ export class HaloPsaTrigger implements INodeType {
{}
);
} catch (error) {
console.error('Failed to create HaloPSA notification for webhook', error);
}
}

Expand Down Expand Up @@ -354,6 +359,7 @@ export class HaloPsaTrigger implements INodeType {

return true;
} catch (error) {
console.error('Failed to delete HaloPSA webhook', error);
return false;
}
},
Expand Down
14 changes: 14 additions & 0 deletions nodes/HaloPSA/halopsa.dark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check warning on line 1 in package.json

View workflow job for this annotation

GitHub Actions / audit 

Remove the leftover file "nodes/HaloPSA/HALO_Icon_Halo_PNG1K.svg:Zone.Identifier". Backup, editor, and test-artifact files should not be published with a community node
"name": "n8n-nodes-halopsacomplete",
"version": "5.5.0",
"description": "An n8n node to connect to HaloPSA API",
Expand All @@ -6,7 +6,7 @@
"n8n-community-node-package"
],
"license": "MIT",
"homepage": "",
"homepage": "https://github.com/redanthrax/halopsa-node",
"author": {
"name": "redanthrax",
"email": "red@4c.gg"
Expand Down
Loading