Repository navigation
Bundle the mesh engine from the mesh-avatar npm package - #5
Merged
Merged
Conversation
mesh-avatar-studio now publishes its runtime as mesh-avatar on npm. Build it from that development dependency, pinned to exactly 0.1.1, instead of a sibling ../mesh-avatar-studio checkout (whose src/engine/ has moved to packages/runtime/ upstream). The package still ships the engine prebuilt in dist/engine/, so installs need neither mesh-avatar nor esbuild. - src/engine.ts: bundle from the installed package; --engine / AVATARSCRIPT_MESH_ENGINE name a checkout's packages/runtime instead - scripts/build.ts: record package name and version in source.json; license as LICENSE.mesh-avatar - CI: drop the mesh-avatar-studio checkouts and commit pin; check the bundled version against package.json - smoke.sh: fail if mesh-avatar is installed with the package Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
@codex review |
A mesh-avatar-studio checkout older than packages/runtime keeps the engine at src/engine/index.ts (as at 8713e85, the commit 0.4 bundled). Accept both layouts so an existing --engine / AVATARSCRIPT_MESH_ENGINE keeps working. Found by Codex review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mesh-avatar-studio now publishes its runtime as mesh-avatar on npm. This PR bundles the engine from that package (a dev dependency pinned to exactly
0.1.1) instead of a../mesh-avatar-studiocheckout. The engine's old path,src/engine/index.ts, has moved topackages/runtime/upstream, so the checkout-based build no longer worked against upstream main anyway.Changes
src/engine.ts: bundles from the installedmesh-avatar(resolved withimport.meta.resolve, because the package exports only animportcondition).--engine <dir>/AVATARSCRIPT_MESH_ENGINEstill bundle from a checkout, now itspackages/runtime/src/index.ts, for trying engine changes before they are published.scripts/build.ts:dist/engine/source.jsonrecords the package name and version instead of a git commit. The license is shipped asLICENSE.mesh-avatar.MESH_AVATAR_STUDIO_REF. The bundled-engine check comparessource.jsonwith the version pinned in package.json.scripts/smoke.sh: also fails ifmesh-avatarends up installed alongside the package. The engine must come prebuilt.Engine version
This moves the engine from upstream commit 8713e85 to mesh-avatar 0.1.1. Its API is a superset of what the render page uses.
Testing
npm run lint,npm run typecheckandnpm test(71 tests) all pass, andnpm run buildsucceeds.scripts/smoke.sh avatars/anipasses for both the CLI and the library.avatars/aniat 1280×720 from source with--tts mockand with--tts openai, and watched both. Lip-sync and motions look right.🤖 Generated with Claude Code
work in avatarscript