Repository navigation
chore: use yarn only; drop package-lock.json - #10
Merged
Merged
Conversation
- Remove package-lock.json; yarn.lock is the single lockfile. - Add vite as a devDependency: vitest 5 lists it as a peer, which npm installed automatically but yarn v1 does not. - CI installs with `yarn install --frozen-lockfile` and runs scripts via yarn. - prepack, CLAUDE.md, README (development) and comments use yarn. - scripts/smoke.sh and the README's user install commands keep npm: they model an end user installing the published package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo had both package-lock.json and yarn.lock. Remove package-lock.json and make yarn the only package manager.
package-lock.json..prettierignorenow namesyarn.lockinstead.vite(^8.3.2) as a devDependency. vitest 5 declares vite as a peer dependency. npm installed it automatically, but yarn v1 does not, so with yarn aloneyarn testfailed withCannot find package 'vite'. yarn.lock locks it at 8.3.4 (the range floor^8.3.2is the version npm had installed); tests and the smoke test ran on 8.3.4.cache: yarn,yarn install --frozen-lockfile, and scripts run viayarn.prepack, CLAUDE.md, the README's development section and code comments now use yarn.scripts/smoke.shand the README's user install commands (npm install avatarscript/npx) stay on npm on purpose: they model an end user installing the published package.Test plan
yarn install --frozen-lockfileyarn format:check/yarn lint/yarn typecheckyarn test(80/80)scripts/smoke.sh avatars/ani(package smoke passed)🤖 Generated with Claude Code
work in avatarscript