Skip to content

internal: Use monorepo:react preset for the react Renovate group - #4402

Merged
ntucker merged 4 commits into
masterfrom
claude/renovate-rn-group-nn0jmd
Oct 17, 2026
Merged

ntucker merged 4 commits into
masterfrom
claude/renovate-rn-group-nn0jmd

Conversation

@ntucker

@ntucker ntucker commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Lead Engineer: Follow-up to #4400 (puts React Native packages in their own Renovate PR), applying Staff's CHANGE_THIS_PR from that review comment.

Why a new PR: #4400 was squash-merged (6a3e0a6) before this fix landed, and its branch was deleted. My cloud agent's commit 00f4fca recreated the branch, but no PR was open, so this opens one. Without it, master keeps the inline list.

Motivation: Renovate's monorepo:react preset already covers both facebook/react and react/react (since 2026-07-22, Renovate #44780/#44782), and #4398 (React 19.3.1, published from react/react) already grouped correctly on Renovate 44.164.1 under the preset. The inline matchSourceUrls list is redundant, and its description — claiming monorepo:react only knows facebook/react — is false and would mislead future maintainers.

Change: in .github/renovate.json, the groupName: "react" rule now uses "extends": ["monorepo:react"] and drops the inline matchSourceUrls list and its description. The react-native packages group from #4400 is unchanged.

What was checked: the agent validated the file parses as JSON (node -e JSON.parse, exit 0). No Renovate config validator is configured in the repo, and Renovate itself was not run, so the grouping behavior is from Staff's reading of the preset and the #4398 evidence, not from a Renovate run. I read master's .github/renovate.json and confirmed it still has the inline list. Not merging — Reviewer to review.


Note

Low Risk
Renovate-only config change; no runtime or application code affected.

Overview
The react Renovate packageRules entry now extends monorepo:react instead of maintaining a hand-written matchSourceUrls list for facebook/react and react/react, and the outdated comment that claimed the preset only knew the old org is removed.

Grouping behavior should stay the same (both repos are covered by the upstream preset), with less config to maintain and no misleading docs in-repo.

Reviewed by Cursor Bugbot for commit 0a2f3fc. Bugbot is set up for automated code reviews on this repo. Configure here.

claude and others added 2 commits October 17, 2026 19:01
React Native minors are breaking (0.x) and were landing in the all
non-major PR. Group react-native, @react-native/*, react-native-*,
React Navigation and the RN testing library together instead. Also
match React's new react/react source URL, which monorepo:react misses.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012xWuQxjEquUmNR4ZPpB4Xg
Co-authored-by: Nathaniel Tucker <me@ntucker.me>
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0a2f3fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T19:13:45.248904Z 00f4fca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ntucker commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

Staff engineer (Cursor agent): CHANGE_THIS_PR. The end state is right, but as the branch stands, squash-merging this PR is a no-op for .github/renovate.json. Master would keep the inline matchSourceUrls list.

Why: the branch still carries the unsquashed #4400 commit 01ea8b75, and its merge-base with master is a50e3aa0 (before #4400). Relative to that merge-base, 01ea8b75 swaps the react rule to the inline list and 00f4fca4 swaps it back, so the branch's net change never touches the react rule. Master's side of the three-way merge (the inline list from squash 6a3e0a66) therefore wins. That's also why Files changed shows only the react-native group, which is already on master, and nothing about the react rule.

Fix (no force-push needed): merge master into this branch (it merges cleanly and brings the inline list back), then add one commit on top that swaps the react rule to "extends": ["monorepo:react"] and drops the description. After that, Files changed should show only the react-rule hunk. Opening a fresh branch from master with that single change and closing this PR works too. Adding a commit on top without merging master first won't help.

What was validated, and how:

  • I read renovate.json (raw fetches) at master 6a3e0a66, head 00f4fca4, and GitHub's test merge commit for this PR, 7ade2f6b. The test merge's file is byte-identical to master's.
  • The compare API confirms merge-base a50e3aa0, with the branch 2 commits ahead and 1 behind. 01ea8b75's file is byte-identical to master's.
  • A local plain-git three-way merge of the fetched file versions reproduces master's content with no conflict.
  • I re-checked Renovate's lib/data/monorepo.json on main: repoGroups.react lists both facebook/react and react/react, so the preset is the right target.

Inferred, not tested: that GitHub's squash builds the same tree as its test merge. A local git rebase happens to reach the intended state, but GitHub's rebase-merge wasn't tested, and squash is the house merge method anyway, so don't rely on it.

No Renovate run was done.

ntucker commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

Lead Engineer: Applying Staff's CHANGE_THIS_PR (comment) with a cloud agent on this branch. Please hold off pushing here until it lands.

Motivation / finding: this branch was rebuilt on the unsquashed #4400 commit 01ea8b7 (merge-base a50e3aa against master), so its net change never touches the react rule. GitHub's test merge is byte-identical to master for .github/renovate.json, meaning a squash merge of #4402 as-is would keep master's inline matchSourceUrls list and change nothing.

Fix (no force-push): merge master into this branch, resolve .github/renovate.json so the groupName: "react" rule is "extends": ["monorepo:react"] with the inline list and its false description dropped, and commit that swap. After this, Files changed against master should show only the react-rule hunk, and the react-native packages group stays as merged in #4400.

What I checked: PR head is still 00f4fca and master is still 6a3e0a6, so no fix has landed yet. I haven't run Renovate; validation will be JSON parsing plus the PR's file diff.

cursoragent and others added 2 commits October 17, 2026 19:15
…group-nn0jmd

Co-authored-by: Nathaniel Tucker <me@ntucker.me>
Merging master restored the inline matchSourceUrls rule from the
squashed React Native grouping commit. Put the react group back on
the monorepo:react preset.

Co-authored-by: Nathaniel Tucker <me@ntucker.me>
@ntucker
ntucker added this pull request to the merge queue Oct 17, 2026
Merged via the queue into master with commit 4b392ce Oct 17, 2026
28 checks passed
@ntucker
ntucker deleted the claude/renovate-rn-group-nn0jmd branch October 17, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants