Repository navigation
internal: Use monorepo:react preset for the react Renovate group - #4402
Conversation
React Native minors are breaking (0.x) and were landing in the all non-major PR. Group react-native, @react-native/*, react-native-*, React Navigation and the RN testing library together instead. Also match React's new react/react source URL, which monorepo:react misses. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012xWuQxjEquUmNR4ZPpB4Xg
Co-authored-by: Nathaniel Tucker <me@ntucker.me>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Staff engineer (Cursor agent): CHANGE_THIS_PR. The end state is right, but as the branch stands, squash-merging this PR is a no-op for Why: the branch still carries the unsquashed #4400 commit Fix (no force-push needed): merge What was validated, and how:
Inferred, not tested: that GitHub's squash builds the same tree as its test merge. A local No Renovate run was done. |
|
Lead Engineer: Applying Staff's CHANGE_THIS_PR (comment) with a cloud agent on this branch. Please hold off pushing here until it lands. Motivation / finding: this branch was rebuilt on the unsquashed #4400 commit 01ea8b7 (merge-base a50e3aa against master), so its net change never touches the react rule. GitHub's test merge is byte-identical to master for Fix (no force-push): merge master into this branch, resolve What I checked: PR head is still 00f4fca and master is still 6a3e0a6, so no fix has landed yet. I haven't run Renovate; validation will be JSON parsing plus the PR's file diff. |
…group-nn0jmd Co-authored-by: Nathaniel Tucker <me@ntucker.me>
Merging master restored the inline matchSourceUrls rule from the squashed React Native grouping commit. Put the react group back on the monorepo:react preset. Co-authored-by: Nathaniel Tucker <me@ntucker.me>
Lead Engineer: Follow-up to #4400 (puts React Native packages in their own Renovate PR), applying Staff's CHANGE_THIS_PR from that review comment.
Why a new PR: #4400 was squash-merged (6a3e0a6) before this fix landed, and its branch was deleted. My cloud agent's commit 00f4fca recreated the branch, but no PR was open, so this opens one. Without it, master keeps the inline list.
Motivation: Renovate's
monorepo:reactpreset already covers bothfacebook/reactandreact/react(since 2026-07-22, Renovate #44780/#44782), and #4398 (React 19.3.1, published from react/react) already grouped correctly on Renovate 44.164.1 under the preset. The inlinematchSourceUrlslist is redundant, and its description — claimingmonorepo:reactonly knows facebook/react — is false and would mislead future maintainers.Change: in
.github/renovate.json, thegroupName: "react"rule now uses"extends": ["monorepo:react"]and drops the inlinematchSourceUrlslist and its description. Thereact-native packagesgroup from #4400 is unchanged.What was checked: the agent validated the file parses as JSON (
node -eJSON.parse, exit 0). No Renovate config validator is configured in the repo, and Renovate itself was not run, so the grouping behavior is from Staff's reading of the preset and the #4398 evidence, not from a Renovate run. I read master's.github/renovate.jsonand confirmed it still has the inline list. Not merging — Reviewer to review.Note
Low Risk
Renovate-only config change; no runtime or application code affected.
Overview
The react Renovate
packageRulesentry nowextendsmonorepo:reactinstead of maintaining a hand-writtenmatchSourceUrlslist forfacebook/reactandreact/react, and the outdated comment that claimed the preset only knew the old org is removed.Grouping behavior should stay the same (both repos are covered by the upstream preset), with less config to maintain and no misleading docs in-repo.
Reviewed by Cursor Bugbot for commit 0a2f3fc. Bugbot is set up for automated code reviews on this repo. Configure here.