Skip to content

Update GoogleTest for Clang 21 compatibility - #2097

Merged
cipolleschi merged 3 commits into
react:mainfrom
cipolleschi:reconcile-yoga-cloning-fast-path
Nov 20, 2026
Merged

cipolleschi merged 3 commits into
react:mainfrom
cipolleschi:reconcile-yoga-cloning-fast-path

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Update the native test dependency from GoogleTest 1.12.1 to 1.18.0 so the test suite compiles with Clang 21 and -Werror. The older dependency uses an implicit char8_t conversion that Clang rejects while building the test framework, before any Yoga tests run. GoogleTest 1.18.0 uses an explicit conversion.

Raise the minimum CMake version in tests/CMakeLists.txt to 3.16 to match GoogleTest 1.18.0's requirement.

Changelog: [Internal]

Test plan

  • macOS arm64, Apple Clang 21.0.0: all 889 native tests passed in both Debug and Release using GoogleTest 1.18.0 with -Werror enabled.
  • Full yarn format-check and git diff --check passed.

Commands run from the repository root, using the existing configured build directories:

cmake --build /tmp/yoga-reconciliation-8hincgw0/ci-fix-debug --parallel 4
/tmp/yoga-reconciliation-8hincgw0/ci-fix-debug/yogatests
cmake --build /tmp/yoga-reconciliation-8hincgw0/ci-fix-release --parallel 4
/tmp/yoga-reconciliation-8hincgw0/ci-fix-release/yogatests
yarn format-check

@cipolleschi cipolleschi changed the title Keep the child-cloning loop on the layout fast path Update GoogleTest for Clang 21 compatibility Nov 20, 2026
@cipolleschi
cipolleschi marked this pull request as ready for review November 20, 2026 17:56
@cipolleschi
cipolleschi merged commit 503bec3 into react:main Nov 20, 2026
33 checks passed
@cipolleschi
cipolleschi deleted the reconcile-yoga-cloning-fast-path branch November 20, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant