Skip to content

test(iOS): cover the Configure Bundler prefill host and port - #60186

Open
ArekChr wants to merge 1 commit into
react:mainfrom
ArekChr:test/configure-bundler-prefill
Open

ArekChr wants to merge 1 commit into
react:mainfrom
ArekChr:test/configure-bundler-prefill

Conversation

@ArekChr

@ArekChr ArekChr commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Summary:

Follow-up to #59878, as asked in review: add tests that check that when jsLocation has no port, Configure Bundler does not fall back to the port of the bundle URL.

RCTDevMenuGetCurrentBundler now takes the bundle URL, jsLocation, packager scheme and ip.txt contents as arguments instead of reading them itself, and is exposed in RCTDevMenu.h for testing. The call site reads them as before, so behavior does not change.

RCTDevMenuTests covers each source of the host and port: bundle URL, jsLocation (with and without a scheme, IPv6), ip.txt, and the localhost default.

Changelog:

[Internal]

Test Plan:

xcodebuild test -workspace RNTesterPods.xcworkspace -scheme RNTester -only-testing:RNTesterUnitTests/RCTDevMenuTests on an iOS 26.2 simulator: 8 tests pass.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2026
@facebook-github-tools facebook-github-tools Bot added p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant