Skip to content

Add ReactTextView regression test for effect spans without remeasure - #59769

Merged
meta-codesync[bot] merged 2 commits into
react:mainfrom
Abbondanzo:export-D129186364
Nov 20, 2026
Merged

meta-codesync[bot] merged 2 commits into
react:mainfrom
Abbondanzo:export-D129186364

Conversation

@Abbondanzo

Copy link
Copy Markdown
Contributor

Summary:
A frame-preserving text update can reach ReactTextView.onDraw without a Layout, in which case effect spans (underline, strikethrough) were skipped and only plain text painted. This pins the corrected behavior: after setText carrying an effect span with no intervening measure, drawing still invokes the span hooks.

Changelog: [Internal]

Differential Revision: D129186364

…oad the correct commit data.

Differential Revision: D129144546
Summary:
A frame-preserving text update can reach `ReactTextView.onDraw` without a `Layout`, in which case effect spans (underline, strikethrough) were skipped and only plain text painted. This pins the corrected behavior: after `setText` carrying an effect span with no intervening measure, drawing still invokes the span hooks.

Changelog: [Internal]

Differential Revision: D129186364
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 2, 2026
@facebook-github-tools facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Nov 2, 2026
@meta-codesync

meta-codesync Bot commented Nov 2, 2026

Copy link
Copy Markdown

@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129186364.

@meta-codesync
meta-codesync Bot merged commit a5b0bf0 into react:main Nov 20, 2026
63 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Abbondanzo in a5b0bf0

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants