Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
huntie
changed the title
huntie
marked this pull request as ready for review
October 8, 2026 15:29
facebook-github-tools
Bot
added
the
Shared with Meta
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D124115690. |
vzaidman
approved these changes
Oct 8, 2026
|
@Abbondanzo merged this pull request in 88a8bd2. |
cipolleschi
pushed a commit
that referenced
this pull request
Oct 26, 2026
Summary: Minimal fixes to the LogBox notification toasts for the iPhone Duo, where they stretch across the unfolded display and block the tab bar beside them when folded. - Cap the toasts at 600pt wide and center them, so they no longer span the unfolded display edge to edge. - **Fix**: Pass touches outside the toasts through to the app, so the folded Duo's rail tab bar beside them stays tappable. - **Fix**: Raise the dismiss ×'s contrast from about 2.5:1 to about 7:1. Previously, it drew in the toast's own color on a mid-gray circle and read as **faint/invisible**; the icon is unchanged. - **Tweak**: Round corners from 8 to 12px. | Before | After | |---|---| | <img src="https://github.com/user-attachments/assets/612d33c1-8d93-4a47-8bd5-5d3c118fb5c4" width="400" /> | <img src="https://github.com/user-attachments/assets/ae436c7d-06b6-4f7f-a07c-5ee7cbe51aef" width="400" /> | Changelog: [General][Fixed] - **LogBox**: Fix bottom notification appearance/touch targets on iPhone Duo Pull Request resolved: #58958 Test Plan: ``` yarn test packages/react-native/Libraries/LogBox ``` **iPhone Duo, folded** | Before | Before, tab bar blocked | After | |---|---|---| | <img src=--sanitized-- Reviewed By: vzaidman Differential Revision: D124115690 Pulled By: Abbondanzo fbshipit-source-id: 0844b21f898d309eff50235147dc5f0bb8b9ca3e (cherry picked from commit 88a8bd2)
tvinhas
pushed a commit
to tvinhas/react-native-macos
that referenced
this pull request
Oct 28, 2026
) Summary: Minimal fixes to the LogBox notification toasts for the iPhone Duo, where they stretch across the unfolded display and block the tab bar beside them when folded. - Cap the toasts at 600pt wide and center them, so they no longer span the unfolded display edge to edge. - **Fix**: Pass touches outside the toasts through to the app, so the folded Duo's rail tab bar beside them stays tappable. - **Fix**: Raise the dismiss ×'s contrast from about 2.5:1 to about 7:1. Previously, it drew in the toast's own color on a mid-gray circle and read as **faint/invisible**; the icon is unchanged. - **Tweak**: Round corners from 8 to 12px. | Before | After | |---|---| | <img src="https://github.com/user-attachments/assets/612d33c1-8d93-4a47-8bd5-5d3c118fb5c4" width="400" /> | <img src="https://github.com/user-attachments/assets/ae436c7d-06b6-4f7f-a07c-5ee7cbe51aef" width="400" /> | Changelog: [General][Fixed] - **LogBox**: Fix bottom notification appearance/touch targets on iPhone Duo Pull Request resolved: react#58958 Test Plan: ``` yarn test packages/react-native/Libraries/LogBox ``` **iPhone Duo, folded** | Before | Before, tab bar blocked | After | |---|---|---| | <img src=--sanitized-- Reviewed By: vzaidman Differential Revision: D124115690 Pulled By: Abbondanzo fbshipit-source-id: 0844b21f898d309eff50235147dc5f0bb8b9ca3e (cherry picked from commit 88a8bd2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal fixes to the LogBox notification toasts for the iPhone Duo, where they stretch across the unfolded display and block the tab bar beside them when folded.
Changelog:
[General][Fixed] - LogBox: Fix bottom notification appearance/touch targets on iPhone Duo
Test Plan
iPhone Duo, folded
✅ With both toasts showing, tapping the rail's APIs tab beside them does nothing before the change and switches tabs after it. Tapping a toast still opens the inspector.
iPhone Duo, unfolded
✅ The toasts span the display before the change and are capped and centered after it.