Skip to content

Reclassify renderer CSS as for-frameworks (#58788) - #58788

Closed
coado wants to merge 1 commit into
react:mainfrom
coado:export-D119642784
Closed

coado wants to merge 1 commit into
react:mainfrom
coado:export-D119642784

Conversation

@coado

@coado coado commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Reclassify the renderer CSS headers (react/renderer/css/*.h) as framework-tier APIs by switching them from the public umbrella guard to the for-frameworks guard. Framework integrations keep access to the fine-grained headers and acknowledge that usage by defining RN_ALLOW_FRAMEWORKS.

Remove the React/CSS.h umbrella and stop publishing it from Buck, CocoaPods, Android prefab, the iOS prebuild header config, and the iOS prebuild header linking step. Its only consumer, the attributed string conversions header (itself framework-tier), now includes the CSS headers it uses (CSSFontVariant.h and CSSValueParser.h) directly.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D119642784

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Oct 1, 2026
@meta-codesync

meta-codesync Bot commented Oct 1, 2026

Copy link
Copy Markdown

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119642784.

coado added a commit to coado/react-native that referenced this pull request Oct 2, 2026
Summary:
Pull Request resolved: react#58788

Reclassify the renderer CSS headers (`react/renderer/css/*.h`) as framework-tier APIs by switching them from the public umbrella guard to the for-frameworks guard. Framework integrations keep access to the fine-grained headers and acknowledge that usage by defining `RN_ALLOW_FRAMEWORKS`.

Remove the `React/CSS.h` umbrella, which has no consumers, and stop publishing it from Buck, CocoaPods, Android prefab, the iOS prebuild header config, and the iOS prebuild header linking step.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D119642784
@meta-codesync meta-codesync Bot changed the title Reclassify renderer CSS as for-frameworks Reclassify renderer CSS as for-frameworks (#58788) Oct 2, 2026
@coado
coado force-pushed the export-D119642784 branch from f5c17e0 to 2a59c5f Compare October 2, 2026 11:04
@meta-codesync meta-codesync Bot changed the title Reclassify renderer CSS as for-frameworks (#58788) Reclassify renderer CSS as for-frameworks Oct 2, 2026
@coado
coado force-pushed the export-D119642784 branch from 2a59c5f to d3ca48b Compare October 2, 2026 15:49
Summary:
Pull Request resolved: react#58788

Reclassify the renderer CSS headers (`react/renderer/css/*.h`) as framework-tier APIs by switching them from the public umbrella guard to the for-frameworks guard. Framework integrations keep access to the fine-grained headers and acknowledge that usage by defining `RN_ALLOW_FRAMEWORKS`.

Remove the `React/CSS.h` umbrella and stop publishing it from Buck, CocoaPods, Android prefab, the iOS prebuild header config, and the iOS prebuild header linking step. Its only consumer, the attributed string conversions header (itself framework-tier), now includes the CSS headers it uses (`CSSFontVariant.h` and `CSSValueParser.h`) directly.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D119642784
@meta-codesync meta-codesync Bot changed the title Reclassify renderer CSS as for-frameworks Reclassify renderer CSS as for-frameworks (#58788) Oct 5, 2026
@coado
coado force-pushed the export-D119642784 branch from d3ca48b to 72428da Compare October 5, 2026 08:55
@meta-codesync meta-codesync Bot closed this in 0aadc94 Oct 5, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 5, 2026
@meta-codesync

meta-codesync Bot commented Oct 5, 2026

Copy link
Copy Markdown

This pull request has been merged in 0aadc94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant