Isolate Activity Result support in its own Buck target - #58752
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: Move Android Activity Result support out of the bridge target's aggregate source list and into a dedicated library. Reuse the bridge's lifecycle interface and inject an `ActivityResultRegistryProvider` plus an exception callback into the implementation. `ReactContext` owns registry discovery and lifecycle-listener registration, so the new target's only React bridge dependency is the bridge interfaces target. Remove the individual source export shims, make the bridge depend on the new target, and give Activity Result tests direct friend access to the implementation target. Changelog: [Internal] - Isolate Android Activity Result support in its own build target Differential Revision: D121859455
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121859455. |
|
This pull request has been merged in 085caf0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move Android Activity Result support out of the bridge target's aggregate source list and into a dedicated library. Reuse the bridge's lifecycle interface and inject an
ActivityResultRegistryProviderplus an exception callback into the implementation.ReactContextowns registry discovery and lifecycle-listener registration, so the new target's only React bridge dependency is the bridge interfaces target.Remove the individual source export shims, make the bridge depend on the new target, and give Activity Result tests direct friend access to the implementation target.
Changelog:
[Internal] - Isolate Android Activity Result support in its own build target
Differential Revision: D121859455