Skip to content

Log unrecognized font family on Android #58751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mosab-nasrallah wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Open

Log unrecognized font family on Android #58751

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2b9cb5
Log unrecognized font family on Android
mosab-nasrallah Sep 29, 2026
d0950d5
Clarify font fallback log message
mosab-nasrallah Sep 29, 2026
6813556
Only log unrecognized font families, matching iOS
mosab-nasrallah Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...ct-native/ReactAndroid/src/main/java/com/facebook/react/common/assets/ReactFontManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import android.content.Context
import android.content.res.AssetManager
import android.graphics.Typeface
import android.os.Build
import android.util.Log
import android.util.SparseArray
import androidx.core.content.res.ResourcesCompat
import com.facebook.react.common.ReactConstants
Expand Down Expand Up @@ -162,6 +163,8 @@ public class ReactFontManager {
private val EXTENSIONS = arrayOf("", "_bold", "_italic", "_bold_italic")
private val FILE_EXTENSIONS = arrayOf(".ttf", ".otf")
private const val FONTS_ASSET_PATH = "fonts/"
// Android's default font family.
private const val DEFAULT_FAMILY = "sans-serif"

private val _instance = ReactFontManager()

Expand All @@ -184,7 +187,13 @@ public class ReactFontManager {
}
}
}
return Typeface.create(fontFamilyName, style)

val typeface = Typeface.create(fontFamilyName, style)
// Typeface.create returns the default typeface for unknown family names.
if (fontFamilyName != DEFAULT_FAMILY && typeface == Typeface.defaultFromStyle(style)) {

@javache javache Oct 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're now paying an extra cost to create an extra Typeface, just to log this warning. That doesn't seem like a good tradeoff.

Log.i(ReactConstants.TAG, "Unrecognized font family '$fontFamilyName'")
}
return typeface
}
}

Expand Down
Loading