Generate public feature flags entry point (#58742) - #58742
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D122353811
branch
from
September 30, 2026 08:04
9e1efcb to
f65c060
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 30, 2026
Summary: Adds a `dangerouslyExposeInPublicCppHeaders` option to the feature flags config. Flags that opt in are generated into `ReactNativePublicFeatureFlags.h`, whose getters forward to `ReactNativeFeatureFlags` from a generated `.cpp`, so exported headers can read them without including the rest of the module. Opts in the flags that exported headers currently read inline. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D122353811
j-piasecki
force-pushed
the
export-D122353811
branch
from
September 30, 2026 08:05
f65c060 to
99b1aec
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 30, 2026
Summary: Pull Request resolved: react#58742 Adds a `dangerouslyExposeInPublicCppHeaders` option to the feature flags config. Flags that opt in are generated into `ReactNativePublicFeatureFlags.h`, whose getters forward to `ReactNativeFeatureFlags` from a generated `.cpp`, so exported headers can read them without including the rest of the module. Opts in the flags that exported headers currently read inline. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D122353811
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122353811. |
Summary: Pull Request resolved: react#58742 Adds a `dangerouslyExposeInPublicCppHeaders` option to the feature flags config. Flags that opt in are generated into `ReactNativePublicFeatureFlags.h`, whose getters forward to `ReactNativeFeatureFlags` from a generated `.cpp`, so exported headers can read them without including the rest of the module. Opts in the flags that exported headers currently read inline. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D122353811
j-piasecki
force-pushed
the
export-D122353811
branch
from
September 30, 2026 08:14
99b1aec to
2be9e30
Compare
|
This pull request has been merged in 6a6e599. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a
dangerouslyExposeInPublicCppHeadersoption to the feature flags config. Flags that opt in are generated intoReactNativePublicFeatureFlags.h, whose getters forward toReactNativeFeatureFlagsfrom a generated.cpp, so exported headers can read them without including the rest of the module. Opts in the flags that exported headers currently read inline.Changelog: [Internal]
Reviewed By: rubennorte
Differential Revision: D122353811